Skip to content

Commit f25bd52

Browse files
authored
Merge pull request #20 from opf/upstream-update
Upstream update
2 parents 3a86723 + d082abd commit f25bd52

52 files changed

Lines changed: 286 additions & 68 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Support Rails edge's custom deprecators
6+
7+
<!-- Changed components: _none_ -->

.changeset/plenty-experts-sort.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@openproject/primer-view-components': minor
3+
---
4+
5+
Support SVGs as leading visuals in `Button` component
6+
7+
<!-- Changed components: Primer::Beta::Button -->

.changeset/smart-scissors-type.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Fix dialog invocation within deferred ActionMenus
6+
7+
<!-- Changed components: Primer::Alpha::ActionMenu -->

.changeset/sweet-bananas-wave.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@openproject/primer-view-components": minor
3+
---
4+
5+
Replace dismiss button in Flash with IconButton
6+
7+
<!-- Changed components: Primer::Beta::Flash -->

.devcontainer/devcontainer.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
"portsAttributes": {
3838
"4000": {
3939
"label": "demo"
40-
},
41-
"5400": {
42-
"label": "doctocat"
4340
}
4441
},
4542
"hostRequirements": {

.github/workflows/demo-preview-destroy.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,34 @@ on:
55
branches:
66
- DO_NOT_EXECUTE_THIS_WORKFLOW
77

8+
permissions:
9+
id-token: write # This is required for requesting the OIDC JWT for authing with Azure
10+
contents: read # This is required for actions/checkout
11+
812
# This allows one deploy workflow to interrupt another
913
concurrency:
1014
group: 'preview-env @ ${{ github.head_ref || github.run_id }} for ${{ github.event.number || github.event.inputs.PR_NUMBER }}'
1115
cancel-in-progress: true
1216

1317
jobs:
14-
destory:
18+
destroy:
1519
if: ${{ github.event.pull_request.head.repo.full_name == 'primer/view_components' && github.actor != 'dependabot[bot]' }}
1620
name: Destroy
1721
runs-on: ubuntu-latest
1822
timeout-minutes: 5
23+
environment:
24+
name: preview
1925
env:
2026
PR_NUMBER: ${{ github.event.number || github.event.inputs.PR_NUMBER }}
2127

2228
steps:
2329
- uses: Azure/login@v1
2430
with:
25-
creds: '{"clientId":"5ad1a188-b944-40eb-a2f8-cc683a6a65a0","clientSecret":"${{ secrets.AZURE_SPN_CLIENT_SECRET }}","subscriptionId":"550eb99d-d0c7-4651-a337-f53fa6520c4f","tenantId":"398a6654-997b-47e9-b12b-9515b896b4de"}'
31+
# excluding a client secret here will cause a login via OpenID Connect (OIDC),
32+
# which prevents us from having to rotate client credentials, etc
33+
client-id: "5ad1a188-b944-40eb-a2f8-cc683a6a65a0"
34+
tenant-id: "398a6654-997b-47e9-b12b-9515b896b4de"
35+
subscription-id: "550eb99d-d0c7-4651-a337-f53fa6520c4f"
2636

2737
- name: Check out repo
2838
uses: actions/checkout@v3
2.12 KB
Loading
2.09 KB
Loading
22.8 KB
Loading
23.3 KB
Loading

0 commit comments

Comments
 (0)