Merge pull request #345 from opf/65869-meeting-status-captions-are-underlined

[65869] All links in page header description are undelined

Author: bsatarnejad

.changeset/unlucky-scissors-rescue.md

@@ -0,0 +1,5 @@
+---
+"@openproject/primer-view-components": patch
+---
+
+[65869] Add an option in the page header description that allows all links in it to be displayed with or without an underline.

app/components/primer/open_project/page_header.pcss

@@ -2,8 +2,8 @@
 
 .PageHeader {
   display: flex;
-  padding-bottom: var(--stack-padding-condensed);
-  margin-bottom: var(--stack-gap-normal);
+  padding-bottom: var(--base-size-8);
+  margin-bottom: var(--base-size-16);
   border-bottom: var(--borderWidth-thin) solid var(--borderColor-muted);
   flex-flow: column;
 }
@@ -47,7 +47,7 @@
   flex: 1 100%;
 }
 
-.PageHeader-description a {
+.PageHeader-description--underlined-links a {
   /* Ensure the accessibility is met, given that the description is written in light grey */
   text-decoration: underline;
 }
@@ -76,7 +76,7 @@
 }
 
 .PageHeader-leadingAction {
-  margin-top: 2px; /* to center align with label */
+  margin-top: var(--base-size-2); /* to center align with label */
   margin-right: var(--base-size-4);
 }
 

app/components/primer/open_project/page_header.rb

@@ -45,11 +45,15 @@ class PageHeader < Primer::Component
       }
 
       # Optional description below the title row
-      renders_one :description, lambda { |**system_arguments|
+      renders_one :description, lambda { |underlined_links: true, **system_arguments|
         deny_tag_argument(**system_arguments)
 
         system_arguments[:tag] = :div
-        system_arguments[:classes] = class_names(system_arguments[:classes], "PageHeader-description")
+        system_arguments[:classes] = class_names(
+          system_arguments[:classes],
+          "PageHeader-description",
+          ("PageHeader-description--underlined-links" if underlined_links)
+        )
 
         Primer::BaseComponent.new(**system_arguments)
       }