Skip to content

Commit ff6cc0d

Browse files
issyl0jonrohan
andauthored
Accept keyword arguments in render_in methods (primer#4091)
Co-authored-by: Jon Rohan <rohan@github.com>
1 parent 2082014 commit ff6cc0d

7 files changed

Lines changed: 11 additions & 6 deletions

File tree

.changeset/soft-stamps-camp.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": patch
3+
---
4+
5+
Accept keyword arguments in `render_in` methods

app/components/primer/alpha/tree_view/sub_tree_node.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def initialize(
164164
)
165165
end
166166

167-
def render_in(*args, &block)
167+
def render_in(*args, **_kwargs, &block)
168168
super.tap do
169169
# check this _after_ rendering so @sub_tree's slots are defined
170170
if @node.select_variant != :none && @sub_tree.defer?

app/components/primer/alpha/tree_view/visual.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def initialize(id:, visual:, label: nil)
1717
@label = label
1818
end
1919

20-
def render_in(_view_context, &block)
20+
def render_in(_view_context, **_kwargs, &block)
2121
block&.call(@visual)
2222
super
2323
end

app/components/primer/beta/button_group.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def initialize(menu_arguments: {}, button_arguments: {})
107107
@button = @menu.with_show_button(icon: "triangle-down", **button_arguments)
108108
end
109109

110-
def render_in(view_context, &block)
110+
def render_in(view_context, **_kwargs, &block)
111111
super(view_context) do
112112
block.call(@menu, @button)
113113
end

app/lib/primer/forms/acts_as_component.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module ActsAsComponent
1010
module InstanceMethods
1111
delegate :render, :content_tag, :output_buffer, :capture, to: :@view_context
1212

13-
def render_in(view_context, &block)
13+
def render_in(view_context, **_kwargs, &block)
1414
@view_context = view_context
1515
before_render
1616
perform_render(&block)

app/lib/primer/forms/toggle_switch_form.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def initialize(**system_arguments)
6969
# assumes the presence of a builder so we create our own here. A builder
7070
# cannot be constructed without a corresponding view context, which is why
7171
# we have to override render_in and can't create it in the initializer.
72-
def render_in(view_context, &block)
72+
def render_in(view_context, **_kwargs, &block)
7373
@builder = Primer::Forms::Builder.new(
7474
nil, nil, view_context, {}
7575
)

lib/primer/form_components.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def initialize(**system_arguments)
1616
@system_arguments = system_arguments
1717
end
1818

19-
def render_in(view_context, &block)
19+
def render_in(view_context, **_kwargs, &block)
2020
builder = Primer::Forms::Builder.new(
2121
nil, nil, view_context, {}
2222
)

0 commit comments

Comments
 (0)