[67727] Preview for hidden SegementedControl in FilterableTreeView is broken - #361
Merged
Conversation
🦋 Changeset detectedLatest commit: ec2061f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kharonus
reviewed
Sep 29, 2025
| <%= render(Primer::OpenProject::FilterableTreeView.new( | ||
| include_sub_items_check_box_arguments: { hidden: !show_checkbox }, | ||
| **(show_segmented_control ? {} : { filter_mode_control_arguments: :none }) | ||
| filter_mode_control_arguments: { hidden: !show_segmented_control } |
Member
|
Do you need a review from another person, as you are today the only person available of your team? |
…e filter function
HDinger
force-pushed
the
bug/67727-on-filterable-tree-view-sub-items-are-not-included-when-sub-item-checkbox-is-ticked
branch
from
September 30, 2025 05:51
410f428 to
ec2061f
Compare
Collaborator
Author
No, one review is enough and the changes are not that critical. |
oliverguenther
approved these changes
Sep 30, 2025
Merged
HDinger
deleted the
bug/67727-on-filterable-tree-view-sub-items-are-not-included-when-sub-item-checkbox-is-ticked
branch
September 30, 2025 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The preview for a hidden SegmentedControl within the FilterableTreeView was broken, because it is actually needed for the filter function. So now, instead of not rendering it at all, we simply hide it (which is consistent to the include sub-items checkbox).
Further, the wrapper around the two is only rendered conditionally, to avoid empty white space when both are hidden.
Screenshots
List the issues that this change affects.
Risk Assessment