diff --git a/.changeset/tough-parts-repeat.md b/.changeset/tough-parts-repeat.md new file mode 100644 index 0000000000..3f9884ef44 --- /dev/null +++ b/.changeset/tough-parts-repeat.md @@ -0,0 +1,5 @@ +--- +'@openproject/primer-view-components': patch +--- + +Change loading spinner for FeedbackMessage and FeedbackDialog diff --git a/app/assets/images/loading_indicator.svg b/app/assets/images/loading_indicator.svg deleted file mode 100644 index 6f42526c43..0000000000 --- a/app/assets/images/loading_indicator.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/components/primer/open_project/feedback_message.rb b/app/components/primer/open_project/feedback_message.rb index b4b73f8652..0b3c95f180 100644 --- a/app/components/primer/open_project/feedback_message.rb +++ b/app/components/primer/open_project/feedback_message.rb @@ -39,7 +39,7 @@ def initialize(icon_arguments: {}, loading: false, **system_arguments) def before_render if @loading - @blankslate.with_visual_image(src: asset_path("loading_indicator.svg"), alt: I18n.t(:label_loading)) + @blankslate.with_visual_spinner(size: :large) elsif @icon_arguments[:icon] != :none @blankslate.with_visual_icon(size: :medium, **@icon_arguments) end diff --git a/test/components/primer/open_project/feedback_dialog_test.rb b/test/components/primer/open_project/feedback_dialog_test.rb index 6a515346b3..f2f422fa00 100644 --- a/test/components/primer/open_project/feedback_dialog_test.rb +++ b/test/components/primer/open_project/feedback_dialog_test.rb @@ -81,7 +81,7 @@ def test_renders_loading_spinner assert_selector("dialog.FeedbackDialog") do assert_selector(".Overlay-body h2", text: "Ups, something went wrong") - assert_selector("img.blankslate-image[src^='/assets/loading_indicator']") + assert_selector("svg.blankslate-image") end end end diff --git a/test/components/primer/open_project/feedback_message_test.rb b/test/components/primer/open_project/feedback_message_test.rb index 479e6053ec..31c95f2a70 100644 --- a/test/components/primer/open_project/feedback_message_test.rb +++ b/test/components/primer/open_project/feedback_message_test.rb @@ -41,7 +41,7 @@ def test_renders_loading_spinner end assert_selector("h2", text: "Ups, something went wrong") - assert_selector("img.blankslate-image[src^='/assets/loading_indicator']") + assert_selector("svg.blankslate-image") end def test_renders_secondary_action