diff --git a/.changeset/many-sheep-yell.md b/.changeset/many-sheep-yell.md new file mode 100644 index 0000000000..68e97e0366 --- /dev/null +++ b/.changeset/many-sheep-yell.md @@ -0,0 +1,5 @@ +--- +'@openproject/primer-view-components': patch +--- + +Align Primer::OpenProject::InputGroup with error messages diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/default.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/default.png index cb467834a5..f7a7a1cec4 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/default.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/default.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/focused.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/focused.png index 81b7626fac..d02befb54a 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/focused.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/segmented_control/trailing_label_width_medium/focused.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/filterable_tree_view/custom_segmented_control/dark_high_contrast.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/filterable_tree_view/custom_segmented_control/dark_high_contrast.png index 6cd8569021..3ad3aa47b8 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/filterable_tree_view/custom_segmented_control/dark_high_contrast.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/filterable_tree_view/custom_segmented_control/dark_high_contrast.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/aria-snapshot.yml b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/aria-snapshot.yml new file mode 100644 index 0000000000..9801015830 --- /dev/null +++ b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/aria-snapshot.yml @@ -0,0 +1,4 @@ +- text: My input group +- textbox "My input group": Copyable value +- button "Copy some text" +- text: Custom validation message \ No newline at end of file diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/default.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/default.png new file mode 100644 index 0000000000..c0a2642043 Binary files /dev/null and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/default.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/focused.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/focused.png new file mode 100644 index 0000000000..74f094b4d9 Binary files /dev/null and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/input_group/with_error_message/focused.png differ diff --git a/app/components/primer/open_project/input_group.html.erb b/app/components/primer/open_project/input_group.html.erb index 0f27558763..ef18afe2ac 100644 --- a/app/components/primer/open_project/input_group.html.erb +++ b/app/components/primer/open_project/input_group.html.erb @@ -4,6 +4,15 @@ <%= trailing_action %> <% end %> + <% if @text_input_validation_message %> +