Skip to content

Git hook pre-commits should be implemented #161

@brianroch

Description

@brianroch

pre-commit is a good tool that could be leveraged.

Checks should match the linting and formatting checks that are performed by the workflows. They could then be executed locally by developers instead of relying on these checks only being performed after updating a PR.

IMO, we shouldn't enforce tests to be green on every local commit using this tool. I think this discourages frequent commits and there are times when tests will be broken in the middle of a refactor. We should rely on contributors to execute tests locally as required. Instead the scope should just be for linting and formatting checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions