-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
pre-commit is a good tool that could be leveraged.
Checks should match the linting and formatting checks that are performed by the workflows. They could then be executed locally by developers instead of relying on these checks only being performed after updating a PR.
IMO, we shouldn't enforce tests to be green on every local commit using this tool. I think this discourages frequent commits and there are times when tests will be broken in the middle of a refactor. We should rely on contributors to execute tests locally as required. Instead the scope should just be for linting and formatting checks.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers