Skip to content

Commit b388435

Browse files
committed
rework docker image bits
1 parent f8ad9c0 commit b388435

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

.github/workflows/publish-docker.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
uses: actions/checkout@v4
1515

1616
- name: build docker image
17-
run: docker build .
17+
run: docker build -t lurker:latest .
1818

1919
- name: log in to github container registry
2020
uses: docker/login-action@v3
@@ -25,6 +25,5 @@ jobs:
2525

2626
- name: publish docker image
2727
run: |
28-
docker load < result
2928
docker tag lurker:latest ghcr.io/${{ github.repository_owner }}/lurker:latest
3029
docker push ghcr.io/${{ github.repository_owner }}/lurker:latest

flake.nix

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
cp -R ./node_modules/* $out/node_modules
4242
ls -la $out/node_modules
4343
'';
44-
outputHash = "sha256-iv1DddCTB1yyu21Ev/c4xtLHSvDas9jQAO2Ob9Iah2Q=";
44+
outputHash = "sha256-wCMsk/gR+U5fCHcRj7Mxvh9Lg6wZAtMn7CvjyCPar+g=";
4545
outputHashAlgo = "sha256";
4646
outputHashMode = "recursive";
4747
};
@@ -73,27 +73,6 @@
7373
7474
'';
7575
};
76-
dockerImage = with final;
77-
final.dockerTools.buildImage {
78-
name = pname;
79-
tag = "latest";
80-
81-
copyToRoot = final.buildEnv {
82-
name = "image-root";
83-
paths = [final.lurker];
84-
pathsToLink = ["/bin"];
85-
};
86-
87-
runAsRoot = ''
88-
mkdir -p /data
89-
'';
90-
91-
config = {
92-
Cmd = ["/bin/${pname}"];
93-
WorkingDir = "/data";
94-
Volumes = {"/data" = {};};
95-
};
96-
};
9776
};
9877

9978
devShell = forAllSystems (system: let
@@ -108,7 +87,7 @@
10887
});
10988

11089
packages = forAllSystems (system: {
111-
inherit (nixpkgsFor."${system}") lurker node_modules dockerImage;
90+
inherit (nixpkgsFor."${system}") lurker node_modules;
11291
});
11392

11493
defaultPackage = forAllSystems (system: nixpkgsFor."${system}".lurker);

readme.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ or with the docker image:
6060
# pull the latest image from gh container registry
6161
$ docker pull ghcr.io/oppiliappan/lurker:latest
6262

63-
# the image will be marked as created on 1970, this is a
64-
# quirk of using nix, it should not affect usage
65-
$ docker image ls
6663
REPOSITORY TAG IMAGE ID CREATED SIZE
6764
ghcr.io/oppiliappan/lurker latest ba3733164889 ??? 227MB
6865

0 commit comments

Comments
 (0)