collapsible_let_in causes infinite recursion

[Lillecarl]

{
  pkgs ? import <nixpkgs> { },
}:
let
  pkgs' = pkgs.extend (import ./overlay.nix);
in
let
  pkgs = pkgs';
in
pkgs

statix suggests this let in can be collapsed:

[W06] Warning: These let-in expressions are collapsible
    ╭─[default.nix:5:1]
    │
  5 │ ╭───▶ let
  8 │ │ ╭─▶ let
 11 │ │ ├─▶ pkgs
    · │ │      │   
    · │ ╰────────── This let in expression is nested
    · │        │   
    · ╰────────┴─── This let in expression contains a nested let in expression
────╯

But this isn't true since keeping it in the same let in block would cause infinite recursion.

[Lymah123]

Hi @mightyiam, I'm a GSoC applicant exploring the codebase and asking if this is still an open problem?

[mightyiam]

@Lymah123 good question. I don't remember. This is a slightly more progressed fork:
https://github.com/molybdenumsoftware/statix

Tests are quite easy to create. So, would you mind creating one, for this, there?

[Lymah123]

@Lymah123 good question. I don't remember. This is a slightly more progressed fork: https://github.com/molybdenumsoftware/statix

Tests are quite easy to create. So, would you mind creating one, for this, there?

Thank you @mightyiam , I am on it.

[Lymah123]

Hi @mightyiam, I've opened a PR with a test and fix for this: Here

[sanskarRaghuvanshi]

Hi @Lillecarl! Is this issue still available? I'd like to work on it.

[mightyiam]

@sanskarRaghuvanshi there's work in progress here