-
Notifications
You must be signed in to change notification settings - Fork 169
prep markdown plugin for publishment #3759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8b975e1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --nx-bail --target=build --parallel |
✅ Succeeded | 28s | View ↗ |
nx run-many --target=test --parallel |
✅ Succeeded | 40s | View ↗ |
nx run-many --target=lint --parallel |
✅ Succeeded | 3s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-22 23:01:58 UTC
| "vitest": "4.0.0-beta.11" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing files field for npm publication
The package is being prepared for publication but lacks a files field in package.json. Without this field, npm will publish all files in the directory except those in .gitignore or .npmignore, potentially including test files, configuration files, and other development artifacts. Other published packages in this repository like @lix-js/sdk and @lix-js/html-diff use "files": ["dist", "src"] to control what gets published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "publishConfig": { | ||
| "access": "public" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing omits dist artifacts
With publishConfig.access set to public this package is now publishable, but there is still no files whitelist or local .npmignore to override the repo-wide .gitignore that ignores every dist directory. When npm/changesets publish runs, the dist/index.js/index.d.ts outputs referenced by exports and types will be excluded from the tarball, so consumers will install a package without its entry point. Consider adding a files list or .npmignore so the built artifacts are shipped.
Useful? React with 👍 / 👎.
|
Cursor Agent can help with this pull request. Just |
Note
Prepare @lix-js/plugin-md for first public npm publish by making the package public and exposing TypeScript types.
packages/lix/plugin-md/package.json):"private"and adding"publishConfig": { "access": "public" }."types": "./dist/index.d.ts"./.changeset/publish-plugin-md.mdfor a minor release announcing first public publish.Written by Cursor Bugbot for commit 8b975e1. This will update automatically on new commits. Configure here.