Skip to content

Conversation

@samuelstroschein
Copy link
Member

@samuelstroschein samuelstroschein commented Nov 22, 2025

Note

Prepare @lix-js/plugin-md for first public npm publish by making the package public and exposing TypeScript types.

  • Package config (packages/lix/plugin-md/package.json):
    • Make package public by removing "private" and adding "publishConfig": { "access": "public" }.
    • Expose TypeScript declarations via "types": "./dist/index.d.ts".
  • Release:
    • Add changeset /.changeset/publish-plugin-md.md for a minor release announcing first public publish.

Written by Cursor Bugbot for commit 8b975e1. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2025

🦋 Changeset detected

Latest commit: 8b975e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@lix-js/host" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "lix-file-manager" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "csv-app" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@nx-cloud
Copy link

nx-cloud bot commented Nov 22, 2025

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 8b975e1

Command Status Duration Result
nx run-many --nx-bail --target=build --parallel ✅ Succeeded 28s View ↗
nx run-many --target=test --parallel ✅ Succeeded 40s View ↗
nx run-many --target=lint --parallel ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-22 23:01:58 UTC

"vitest": "4.0.0-beta.11"
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing files field for npm publication

The package is being prepared for publication but lacks a files field in package.json. Without this field, npm will publish all files in the directory except those in .gitignore or .npmignore, potentially including test files, configuration files, and other development artifacts. Other published packages in this repository like @lix-js/sdk and @lix-js/html-diff use "files": ["dist", "src"] to control what gets published.

Fix in Cursor Fix in Web

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +10 to +11
"publishConfig": {
"access": "public"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Publishing omits dist artifacts

With publishConfig.access set to public this package is now publishable, but there is still no files whitelist or local .npmignore to override the repo-wide .gitignore that ignores every dist directory. When npm/changesets publish runs, the dist/index.js/index.d.ts outputs referenced by exports and types will be excluded from the tarball, so consumers will install a package without its entry point. Consider adding a files list or .npmignore so the built artifacts are shipped.

Useful? React with 👍 / 👎.

@cursor
Copy link

cursor bot commented Nov 22, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@samuelstroschein samuelstroschein merged commit ffec3ca into main Nov 22, 2025
3 checks passed
@samuelstroschein samuelstroschein deleted the publish-plugin-md branch November 22, 2025 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants