Violation of PRIMARY KEY constraint in dbo.@PCounters

[cperez120]

Original query inside the SQLInstance.PerfCounters.cs
`Declare @PCounters Table (object_name nvarchar(128),
counter_name nvarchar(128),
instance_name nvarchar(128),
cntr_value bigint,
cntr_type int,
Primary Key(object_name, counter_name, instance_name));

Insert Into @PCounters
SELECT RTrim(spi.object_name) object_name, RTrim(spi.counter_name) counter_name, RTrim(spi.instance_name) instance_name, spi.cntr_value, spi.cntr_type
From sys.dm_os_performance_counters spi
Where spi.instance_name Not In (Select name From sys.databases)
And spi.object_name Not Like 'SQLServer:Backup Device%'
And spi.object_name Not Like 'SQL Server 2016 XTP%'

WAITFOR DELAY '00:00:01'

Declare @CCounters Table (object_name nvarchar(128),
counter_name nvarchar(128),
instance_name nvarchar(128),
cntr_value bigint,
cntr_type INT,
Primary Key(object_name, counter_name, instance_name));

Insert Into @CCounters
SELECT RTrim(spi.object_name) object_name, RTrim(spi.counter_name) counter_name, RTrim(spi.instance_name) instance_name, spi.cntr_value, spi.cntr_type
From sys.dm_os_performance_counters spi
Where spi.instance_name Not In (Select name From sys.databases)
And spi.object_name Not Like 'SQLServer:Backup Device%'
And spi.object_name Not Like 'SQL Server 2016 XTP%'

SELECT cc.object_name ObjectName,
cc.counter_name CounterName,
cc.instance_name InstanceName,
cc.cntr_value CurrentValue,
(Case cc.cntr_type
When 65792 Then cc.cntr_value -- Count
When 537003264 Then IsNull(Cast(cc.cntr_value as Money) / NullIf(cbc.cntr_value, 0), 0) -- Ratio
When 272696576 Then cc.cntr_value - pc.cntr_value -- Per Second
When 1073874176 Then IsNull(Cast(cc.cntr_value - pc.cntr_value as Money) / NullIf(cbc.cntr_value - pbc.cntr_value, 0), 0) -- Avg
When 1073939712 Then cc.cntr_value - pc.cntr_value -- Base
Else cc.cntr_value
End) CalculatedValue,
cc.cntr_type Type
From @CCounters cc
Left Join @CCounters cbc
On cc.object_name = cbc.object_name
And (Case When cc.counter_name Like '%(ms)' Then Replace(cc.counter_name, ' (ms)',' Base')
When cc.object_name = 'SQLServer:FileTable' Then Replace(cc.counter_name, 'Avg ','') + ' base'
When cc.counter_name = 'Worktables From Cache Ratio' Then 'Worktables From Cache Base'
When cc.counter_name = 'Avg. Length of Batched Writes' Then 'Avg. Length of Batched Writes BS'
Else cc.counter_name + ' base'
End) = cbc.counter_name
And cc.instance_name = cbc.instance_name
And cc.cntr_type In (537003264, 1073874176)
And cbc.cntr_type = 1073939712
Join @PCounters pc
On cc.object_name = pc.object_name
And cc.counter_name = pc.counter_name
And cc.instance_name = pc.instance_name
And cc.cntr_type = pc.cntr_type
Left Join @PCounters pbc
On pc.object_name = pbc.object_name
And pc.instance_name = pbc.instance_name
And (Case When pc.counter_name Like '%(ms)' Then Replace(pc.counter_name, ' (ms)',' Base')
When pc.object_name = 'SQLServer:FileTable' Then Replace(pc.counter_name, 'Avg ','') + ' base'
When pc.counter_name = 'Worktables From Cache Ratio' Then 'Worktables From Cache Base'
When pc.counter_name = 'Avg. Length of Batched Writes' Then 'Avg. Length of Batched Writes BS'
Else pc.counter_name + ' base'
End) = pbc.counter_name
And pc.cntr_type In (537003264, 1073874176)
And pbc.cntr_type = 1073939712`
In SQL server 2008 R2 can cause issues due to a Primary Key constraint.
Violation of PRIMARY KEY constraint 'PK__#08D2134__B516035C0ABA5BB2'. Cannot insert duplicate key in object 'dbo.@PCounters'. The duplicate key value is (MSSQL$:Backup Device, Device Throughput Bytes/sec,G:\Backups\MyDB_Full.bak).

Fix is to add Distinct to the select statements. Once I recompiled the application with the following query `Declare @PCounters Table (object_name nvarchar(128),
counter_name nvarchar(128),
instance_name nvarchar(128),
cntr_value bigint,
cntr_type int,
Primary Key(object_name, counter_name, instance_name));

Insert Into @PCounters
SELECT DISTINCT RTrim(spi.object_name) object_name, RTrim(spi.counter_name) counter_name, RTrim(spi.instance_name) instance_name, spi.cntr_value, spi.cntr_type
From sys.dm_os_performance_counters spi
Where spi.instance_name Not In (Select name From sys.databases)
And spi.object_name Not Like 'SQLServer:Backup Device%'
And spi.object_name Not Like 'SQL Server 2016 XTP%'

WAITFOR DELAY '00:00:01'

Declare @CCounters Table (object_name nvarchar(128),
counter_name nvarchar(128),
instance_name nvarchar(128),
cntr_value bigint,
cntr_type INT,
Primary Key(object_name, counter_name, instance_name));

Insert Into @CCounters
SELECT DISTINCT RTrim(spi.object_name) object_name, RTrim(spi.counter_name) counter_name, RTrim(spi.instance_name) instance_name, spi.cntr_value, spi.cntr_type
From sys.dm_os_performance_counters spi
Where spi.instance_name Not In (Select name From sys.databases)
And spi.object_name Not Like 'SQLServer:Backup Device%'
And spi.object_name Not Like 'SQL Server 2016 XTP%'

SELECT DISTINCT cc.object_name ObjectName,
cc.counter_name CounterName,
cc.instance_name InstanceName,
cc.cntr_value CurrentValue,
(Case cc.cntr_type
When 65792 Then cc.cntr_value -- Count
When 537003264 Then IsNull(Cast(cc.cntr_value as Money) / NullIf(cbc.cntr_value, 0), 0) -- Ratio
When 272696576 Then cc.cntr_value - pc.cntr_value -- Per Second
When 1073874176 Then IsNull(Cast(cc.cntr_value - pc.cntr_value as Money) / NullIf(cbc.cntr_value - pbc.cntr_value, 0), 0) -- Avg
When 1073939712 Then cc.cntr_value - pc.cntr_value -- Base
Else cc.cntr_value
End) CalculatedValue,
cc.cntr_type Type
From @CCounters cc
Left Join @CCounters cbc
On cc.object_name = cbc.object_name
And (Case When cc.counter_name Like '%(ms)' Then Replace(cc.counter_name, ' (ms)',' Base')
When cc.object_name = 'SQLServer:FileTable' Then Replace(cc.counter_name, 'Avg ','') + ' base'
When cc.counter_name = 'Worktables From Cache Ratio' Then 'Worktables From Cache Base'
When cc.counter_name = 'Avg. Length of Batched Writes' Then 'Avg. Length of Batched Writes BS'
Else cc.counter_name + ' base'
End) = cbc.counter_name
And cc.instance_name = cbc.instance_name
And cc.cntr_type In (537003264, 1073874176)
And cbc.cntr_type = 1073939712
Join @PCounters pc
On cc.object_name = pc.object_name
And cc.counter_name = pc.counter_name
And cc.instance_name = pc.instance_name
And cc.cntr_type = pc.cntr_type
Left Join @PCounters pbc
On pc.object_name = pbc.object_name
And pc.instance_name = pbc.instance_name
And (Case When pc.counter_name Like '%(ms)' Then Replace(pc.counter_name, ' (ms)',' Base')
When pc.object_name = 'SQLServer:FileTable' Then Replace(pc.counter_name, 'Avg ','') + ' base'
When pc.counter_name = 'Worktables From Cache Ratio' Then 'Worktables From Cache Base'
When pc.counter_name = 'Avg. Length of Batched Writes' Then 'Avg. Length of Batched Writes BS'
Else pc.counter_name + ' base'
End) = pbc.counter_name
And pc.cntr_type In (537003264, 1073874176)
And pbc.cntr_type = 1073939712` the page did not have anymore errors or issues.