Apply code quality fixes: update comment, rename ApiUrl to APIUrl, extract URL constant

Co-authored-by: adriens <[email protected]>

Author: Copilot

cmd/category.go

@@ -43,7 +43,7 @@ geol category cloud`,
 			log.Fatal().Msgf("Category '%s' not found in cache", category)
 		}
 
-		url := utilities.ApiUrl + "categories/" + category
+		url := utilities.APIUrl + "categories/" + category
 		resp, err := http.Get(url)
 		if err != nil {
 			log.Fatal().Err(err).Msgf("Error requesting category '%s'", category)

cmd/check.go

@@ -191,7 +191,7 @@ func lookupEolDate(idEol, version string) (string, bool, string) {
 	}
 
 	if len(prod) > 0 {
-		url := utilities.ApiUrl + "products/" + prod + "/releases/" + version
+		url := utilities.APIUrl + "products/" + prod + "/releases/" + version
 		resp, err := http.Get(url)
 		if err != nil {
 			log.Error().Err(err).Msgf("Error requesting %s", prod)
@@ -223,7 +223,7 @@ func lookupEolDate(idEol, version string) (string, bool, string) {
 			os.Exit(1)
 		}
 
-		url = utilities.ApiUrl + "products/" + prod
+		url = utilities.APIUrl + "products/" + prod
 		resp, err = http.Get(url)
 		if err != nil {
 			log.Error().Err(err).Msgf("Error requesting %s", prod)

cmd/exports/duckdb.go

@@ -148,7 +148,7 @@ func fetchAllProductData(cmd *cobra.Command) (*allProductsData, error) {
 	go func() {
 		for productName := range products.Products {
 			// Fetch basic product info
-			url := utilities.ApiUrl + "products/" + productName
+			url := utilities.APIUrl + "products/" + productName
 			resp, err := http.Get(url)
 			if err != nil {
 				log.Warn().Err(err).Msgf("Error requesting %s, skipping", productName)
@@ -230,7 +230,7 @@ func fetchAllProductData(cmd *cobra.Command) (*allProductsData, error) {
 // fetchAllCategories retrieves all categories from the API
 func fetchAllCategories() (map[string]utilities.Category, error) {
 	// Fetch categories from API
-	resp, err := http.Get(utilities.ApiUrl + "categories")
+	resp, err := http.Get(utilities.APIUrl + "categories")
 	if err != nil {
 		log.Error().Err(err).Msg("Error fetching categories")
 		return nil, err
@@ -262,7 +262,7 @@ func fetchAllCategories() (map[string]utilities.Category, error) {
 // fetchAllTags retrieves all tags from the API
 func fetchAllTags() (map[string]utilities.Tag, error) {
 	// Fetch tags from API
-	resp, err := http.Get(utilities.ApiUrl + "tags")
+	resp, err := http.Get(utilities.APIUrl + "tags")
 	if err != nil {
 		log.Error().Err(err).Msg("Error fetching tags")
 		return nil, err

cmd/product/describe.go

@@ -125,7 +125,7 @@ var describeCmd = &cobra.Command{
 			os.Exit(1)
 		}
 
-		url := utilities.ApiUrl + "products/" + mainName
+		url := utilities.APIUrl + "products/" + mainName
 		resp, err = http.Get(url)
 		if err != nil {
 			log.Error().Err(err).Msgf("Error requesting %s", mainName)

cmd/product/extended.go

@@ -279,7 +279,7 @@ func renderProductTable(prod ProductReleases, numberFlag int, mdFlag bool, isFir
 
 // FetchProductData retrieves product release data from the API
 func FetchProductData(productName string) (ProductReleases, error) {
-	url := utilities.ApiUrl + "products/" + productName
+	url := utilities.APIUrl + "products/" + productName
 	resp, err := http.Get(url)
 	if err != nil {
 		return ProductReleases{}, fmt.Errorf("error requesting %s: %w", productName, err)

cmd/product/product.go

@@ -73,7 +73,7 @@ geol product describe nodejs`,
 			}
 
 			// API request for this product
-			url := utilities.ApiUrl + "products/" + prod
+			url := utilities.APIUrl + "products/" + prod
 			resp, err := http.Get(url)
 			if err != nil {
 				log.Fatal().Err(err).Msgf("Error requesting %s", prod)

cmd/tag.go

@@ -48,7 +48,7 @@ geol tag canonical`,
 			log.Fatal().Msgf("Tag '%s' not found in cache", tag)
 		}
 
-		url := utilities.ApiUrl + "tags/" + tag
+		url := utilities.APIUrl + "tags/" + tag
 		resp, err := http.Get(url)
 		if err != nil {
 			log.Fatal().Err(err).Msgf("Error requesting tag '%s'", tag)

utilities/categoriesTools.go

@@ -34,7 +34,7 @@ func FetchAndSaveCategories(cmd *cobra.Command) error {
 		return err
 	}
 	// HTTP GET request (extracted)
-	resp, err := GetAPIResponse(ApiUrl + "categories")
+	resp, err := GetAPIResponse(APIUrl + "categories")
 	if err != nil {
 		log.Error().Err(err).Msg("Error during HTTP request")
 		return err

utilities/productTools.go

@@ -61,7 +61,7 @@ func FetchAndSaveProducts(cmd *cobra.Command) error {
 	}
 
 	// HTTP GET request (extracted)
-	resp, err := GetAPIResponse(ApiUrl + "products")
+	resp, err := GetAPIResponse(APIUrl + "products")
 	if err != nil {
 		log.Error().Err(err).Msg("Error during HTTP request")
 		return err

utilities/tagTools.go

@@ -10,6 +10,8 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const tagBaseURL = "https://endoflife.date/api/v1/tags/"
+
 type Tag struct {
 	Name string `json:"name"`
 	Uri  string `json:"uri"`
@@ -34,7 +36,7 @@ func FetchAndSaveTags(cmd *cobra.Command) error {
 		return err
 	}
 	// HTTP GET request (extracted)
-	resp, err := GetAPIResponse(ApiUrl + "tags")
+	resp, err := GetAPIResponse(APIUrl + "tags")
 	if err != nil {
 		log.Error().Err(err).Msg("Error during HTTP request")
 		return err
@@ -105,7 +107,7 @@ func GetTagsWithCacheRefresh(cmd *cobra.Command, tagsPath string) (TagsFile, err
 	return tags, nil
 }
 
-// readAndUnmarshalTags lit le fichier et fait l'unmarshal JSON dans tags.
+// readAndUnmarshalTags reads the file and unmarshals the JSON contents into tags.
 func readAndUnmarshalTags(tagsPath string, tags *TagsFile) error {
 	data, err := os.ReadFile(tagsPath)
 	if err != nil {
@@ -124,7 +126,7 @@ func ConvertTagStringsToTags(tagStrings []string) []Tag {
 	for i, tagName := range tagStrings {
 		tags[i] = Tag{
 			Name: tagName,
-			Uri:  "https://endoflife.date/api/v1/tags/" + tagName,
+			Uri:  tagBaseURL + tagName,
 		}
 	}
 	return tags