Skip to content

Commit 332b87f

Browse files
committed
Fix decision test
1 parent 098f47a commit 332b87f

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

core-api/src/test/java/com/optimizely/ab/notification/DecisionNotificationTest.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,15 @@ public class DecisionNotificationTest {
3737

3838
private static final Boolean FEATURE_ENABLED = Boolean.FALSE;
3939
private static final String EXPERIMENT_KEY = "experimentKey";
40+
private static final String EXPERIMENT_ID = "1234567";
4041
private static final String FEATURE_KEY = "featureKey";
4142
private static final String FEATURE_VARIABLE_KEY = "featureVariableKey";
4243
private static final String FEATURE_TEST = "featureTest";
4344
private static final String FEATURE_TEST_VARIATION = "featureTestVariation";
4445
private static final String USER_ID = "userID";
4546
private static final Map<String, String> USER_ATTRIBUTES = Collections.singletonMap("user", "attr");
4647
private static final Variation VARIATION = mock(Variation.class);
48+
private static final String VARIATION_ID = "1234567";
4749

4850
private FeatureTestSourceInfo featureTestSourceInfo;
4951
private RolloutSourceInfo rolloutSourceInfo;
@@ -58,6 +60,8 @@ public void setUp() {
5860
.withAttributes(USER_ATTRIBUTES)
5961
.withExperimentKey(EXPERIMENT_KEY)
6062
.withVariation(VARIATION)
63+
.withExperimentId(EXPERIMENT_ID)
64+
.withVariationId(VARIATION_ID)
6165
.withType(NotificationCenter.DecisionNotificationType.AB_TEST.toString())
6266
.build();
6367
featureTestSourceInfo = new FeatureTestSourceInfo(FEATURE_TEST, FEATURE_TEST_VARIATION);
@@ -107,6 +111,8 @@ public void testGetDecisionInfo() {
107111
HashMap<String, String> expectedExperimentDecisionInfo = new HashMap<>();
108112
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.EXPERIMENT_KEY, EXPERIMENT_KEY);
109113
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.VARIATION_KEY, VARIATION.getKey());
114+
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.EXPERIMENT_ID, EXPERIMENT_ID);
115+
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.VARIATION_ID, VARIATION_ID);
110116
assertEquals(expectedExperimentDecisionInfo, experimentDecisionNotification.getDecisionInfo());
111117

112118
// Assert for Feature's DecisionInfo
@@ -128,7 +134,7 @@ public void testGetDecisionInfo() {
128134

129135
@Test
130136
public void testToString() {
131-
assertEquals("DecisionNotification{type='ab-test', userId='userID', attributes={user=attr}, decisionInfo={experimentKey=experimentKey, variationKey=null}}", experimentDecisionNotification.toString());
137+
assertEquals("DecisionNotification{type='ab-test', userId='userID', attributes={user=attr}, decisionInfo={experimentKey=experimentKey, variationKey=null, experimentId='1234567', variationId='1234567'}}", experimentDecisionNotification.toString());
132138
assertEquals("DecisionNotification{type='feature', userId='userID', attributes={user=attr}, decisionInfo={featureEnabled=false, sourceInfo={experimentKey=featureTest, variationKey=featureTestVariation}, source=feature-test, featureKey=featureKey}}", featureDecisionNotification.toString());
133139
assertEquals("DecisionNotification{type='feature-variable', userId='userID', attributes={user=attr}, decisionInfo={variableType=string, featureEnabled=true, sourceInfo={}, variableValue=null, variableKey=featureVariableKey, source=rollout, featureKey=featureKey}}", featureVariableDecisionNotification.toString());
134140
}

0 commit comments

Comments
 (0)