Skip to content

Commit dc7e901

Browse files
committed
fix tests
1 parent 7879667 commit dc7e901

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

build.gradle

+13-12
Original file line numberDiff line numberDiff line change
@@ -94,21 +94,22 @@ configure(publishedProjects) {
9494
}
9595

9696
dependencies {
97-
compile group: 'commons-codec', name: 'commons-codec', version: commonCodecVersion
97+
implementation group: 'commons-codec', name: 'commons-codec', version: commonCodecVersion
9898

99-
testCompile group: 'junit', name: 'junit', version: junitVersion
100-
testCompile group: 'org.mockito', name: 'mockito-core', version: mockitoVersion
101-
testCompile group: 'org.hamcrest', name: 'hamcrest-all', version: hamcrestVersion
102-
testCompile group: 'com.google.guava', name: 'guava', version: guavaVersion
99+
testImplementation group: 'junit', name: 'junit', version: junitVersion
100+
testImplementation group: 'org.mockito', name: 'mockito-core', version: mockitoVersion
101+
testImplementation group: 'org.hamcrest', name: 'hamcrest-all', version: hamcrestVersion
102+
testImplementation group: 'com.google.guava', name: 'guava', version: guavaVersion
103103

104104
// logging dependencies (logback)
105-
testCompile group: 'ch.qos.logback', name: 'logback-classic', version: logbackVersion
106-
testCompile group: 'ch.qos.logback', name: 'logback-core', version: logbackVersion
107-
108-
testCompile group: 'com.google.code.gson', name: 'gson', version: gsonVersion
109-
testCompile group: 'org.json', name: 'json', version: jsonVersion
110-
testCompile group: 'com.googlecode.json-simple', name: 'json-simple', version: jsonSimpleVersion
111-
testCompile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jacksonVersion
105+
testImplementation group: 'ch.qos.logback', name: 'logback-classic', version: logbackVersion
106+
testImplementation group: 'ch.qos.logback', name: 'logback-core', version: logbackVersion
107+
testImplementation 'org.mock-server:mockserver-netty:5.1.1'
108+
109+
testImplementation group: 'com.google.code.gson', name: 'gson', version: gsonVersion
110+
testImplementation group: 'org.json', name: 'json', version: jsonVersion
111+
testImplementation group: 'com.googlecode.json-simple', name: 'json-simple', version: jsonSimpleVersion
112+
testImplementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jacksonVersion
112113
}
113114

114115
def docTitle = "Optimizely Java SDK"

core-httpclient-impl/build.gradle

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ dependencies {
22
implementation project(':core-api')
33
compileOnly group: 'com.google.code.gson', name: 'gson', version: gsonVersion
44
implementation group: 'org.apache.httpcomponents', name: 'httpclient', version: httpClientVersion
5-
6-
testImplementation 'org.mock-server:mockserver-netty:5.15.0'
75
}
86

97
task exhaustiveTest {

core-httpclient-impl/src/test/java/com/optimizely/ab/OptimizelyHttpClientTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public void tearDown() {
6464
@Test
6565
public void testDefaultConfiguration() {
6666
OptimizelyHttpClient.Builder builder = builder();
67-
assertEquals(builder.validateAfterInactivity, 5000);
67+
assertEquals(builder.validateAfterInactivity, 1000);
6868
assertEquals(builder.maxTotalConnections, 200);
6969
assertEquals(builder.maxPerRoute, 20);
7070
assertNull(builder.customRetryHandler);

core-httpclient-impl/src/test/java/com/optimizely/ab/event/AsyncEventHandlerTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public void testBuilderWithCustomHttpClient() {
136136
@Test
137137
public void testBuilderWithDefaultHttpClient() {
138138
AsyncEventHandler.Builder builder = builder();
139-
assertEquals(builder.validateAfterInactivity, 5000);
139+
assertEquals(builder.validateAfterInactivity, 1000);
140140
assertEquals(builder.maxTotalConnections, 200);
141141
assertEquals(builder.maxPerRoute, 20);
142142

0 commit comments

Comments
 (0)