Skip to content

Conversation

@toshihikoyanase
Copy link
Member

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

An alternative approach to #1144. Instead of embedding the priority handling logic to _cli.py, this PR will extract it to DashboardConfig.

What does this implement/fix? Explain your changes.

As mentioned in #1144, the config priority is CLI options > config file > default values.
This PR fixes the priority and introduces DashboardConfig class to handle the priority.
It also adds unit tests for the DashboardConfig.

@toshihikoyanase toshihikoyanase marked this pull request as ready for review September 8, 2025 06:32
Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment.

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit a0a2b32 into optuna:main Sep 10, 2025
14 checks passed
@toshihikoyanase toshihikoyanase deleted the fix-config-priority branch September 10, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants