-
Notifications
You must be signed in to change notification settings - Fork 193
Setup Pre-Commit #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Pre-Commit #316
Conversation
|
@gen740 Could you review this PR? |
|
Could you please review the changes? cc: @gen740 |
|
This pull request has not seen any recent activity. |
|
Not stale |
|
Could you please review the changes? cc: @gen740 |
|
I’m so sorry for my late reply, and thank you very much for your pull request! I ran the pre-commit hook on your branch, and the following error occurred: Does this also happen on your machine? Also, it would be really helpful for beginners if you added instructions to CONTRIBUTING.md, just like Optuna does. |
gen740
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!

When I was working on #303, the pre-commit was not setup. This PR does the same. I have taken reference from this repo: https://github.com/optuna/optuna/blob/master/.pre-commit-config.yaml. Please let me know if any improvements are needed and I will make the necessary changes.
cc: @c-bata