Skip to content

Disable scheduled runs for PyTorch and visualization temporarily #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

Disable scheduled runs for PyTorch and visualization temporarily #337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2bff0b
Disable scheduled runs for PyTorch and visualization temporarily
c-bata Oct 29, 2025
62deb7d
Apply review suggestions from sawa3030
c-bata Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/pytorch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: pytorch

on:
schedule:
- cron: '0 15 * * *'
# TODO(c-bata): Uncomment the following lines after fixing the examples.
# See https://github.com/optuna/optuna-examples/issues/336 for details.
# schedule:
# - cron: '0 15 * * *'
Copy link
Collaborator

@sawa3030 sawa3030 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a strong preference, but may I suggest disabling only the skorch step for now? My understanding is that disabling this part alone should be sufficient.

    - name: Run skorch example
      # TODO(c-bata): Uncomment the following lines after fixing the examples.
      # See https://github.com/optuna/optuna-examples/issues/336 for details.
      # schedule:
      if: ${{ github.event_name != 'schedule' }}
      run: |
        python pytorch/skorch_simple.py
      env:
        OMP_NUM_THREADS: 1

Copy link
Member Author

@c-bata c-bata Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review! I applied your suggestion in 62deb7d.

pull_request:
paths:
- 'pytorch/**'
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/visualization.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: visualization

on:
schedule:
- cron: '0 15 * * *'
# TODO(c-bata): Uncomment the following lines after fixing the examples.
# See https://github.com/optuna/optuna-examples/issues/336 for details.
# schedule:
# - cron: '0 15 * * *'
pull_request:
paths:
- 'visualization/**'
Expand Down