Skip to content

Conversation

@msakai
Copy link
Contributor

@msakai msakai commented Nov 12, 2025

Contributor Agreements

Please read the contributor agreements and if you agree, please click the checkbox below.

  • I agree to the contributor agreements.

Tip

Please follow the Quick TODO list to smoothly merge your PR.

Motivation

This PR improves the handling of noisy constants in RobustGPSampler in the following two aspects:

  • Allow specifying nominal values of noisy constants explicitly instead of using the center values of the interval implicitly.

  • Sample noisy constant values first and then optimize other parameter's values based on those values, instead of optimizing optimizing other parameters assuming the noisy constant's nominal values, and then changing the noisy constant's value afterwords. I believe this is desirable because the sampler can explore desirable parameter values under different values of constant noisy parameters.

Description of the changes

TODO List towards PR Merge

Please remove this section if this PR is not an addition of a new package.
Otherwise, please check the following TODO list:

  • Copy ./template/ to create your package
  • Replace <COPYRIGHT HOLDER> in LICENSE of your package with your name
  • Fill out README.md in your package
  • Add import statements of your function or class names to be used in __init__.py
  • (Optional) Add from __future__ import annotations at the head of any Python files that include typing to support older Python versions
  • Apply the formatter based on the tips in README.md
  • Check whether your module works as intended based on the tips in README.md

- Allow specifying nominal values of noisy constants explicitly
  instead of using the center values of the interval.

- Sample noisy constant values first and then optimize other parameter's
  values based on those values, instead of optimizing optimizing other
  parameters assuming the noisy constant's nominal values, and then
  changing the noisy constant's value afterwords.
  I believe this is desirable because the sampler can explore desirable
  parameter values under different noisy constant values.
@msakai msakai force-pushed the var-flexible-noisy-const branch from 009c86f to 5f01a16 Compare November 12, 2025 07:34
@msakai msakai marked this pull request as ready for review November 12, 2025 07:36
@not522 not522 self-assigned this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants