[Feature] affected row count

[tmirko]

Describe the Feature

I would like to see a feature that shows affected row count, similar to sql%rowcount from PL/SQL. I'm aware of the variable "rows_affected" in run_results.json but currently it is always showing 0.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Anything else?

No response

[aosingh]

@Mirko-T

rows_affected is set using cursor.rowcount as seen here

Documentation for cursor.rowcount states the following:

This read-only attribute specifies the number of rows that have currently been fetched from the cursor (for select statements), that have been affected by the operation (for insert, update, delete and merge statements), or the number of successful executions of the statement (for PL/SQL statements).

I added a log line to print rows_affected.

18:29:30.036878 [debug] [Thread-3  ]: oracle adapter: SQL status: OK in 0.2434229850769043 seconds
18:29:30.038162 [info ] [Thread-3  ]: oracle adapter: Affected row count 1

[tmirko]

Hi @aosingh, Thanks for the answer.

I can't find this "Affected row count" log line in my dbt.log file.

I'm using:

dbt version: 1.3.1
python version: 3.10.8
os info: Windows-10-10.0.19042-SP0
Oracle version: Oracle Database 19c Enterprise Edition Release 19.0.0.0.0

[aosingh]

The new log line is local to my development branch. I added it for debugging to verify the value that is set in AdapterResponse

[tmirko]

Can I somehow test it on my end?

[aosingh]

@Mirko-T
Let me publish the debug log to a new git branch. You should be able to pip install pointing to the git branch

[aosingh]

@Mirko-T

You can install the code using the following command. The only change is a new log statement to print cursor.rowcount

pip install git+https://github.com/oracle/dbt-oracle.git@debug/rowcount

[tmirko]

@aosingh

I've installed dbt-oracle from debug/rowcount branch but I can't see any changes regarding additional Affected row count line in log file.

Please reach out if you need more info from my end.

[aosingh]

@Mirko-T

Did you add --debug option to dbt command ? I re-installed from the branch and tested it again

16:54:11.103799 [debug] [Thread-2  ]: oracle adapter: SQL status: OK in 0.18878388404846191 seconds
16:54:11.105054 [info ] [Thread-2  ]: oracle adapter: Affected row count 1

Also, we directly use python driver's cursor.rowcount without any additional changes. That is the way to get this information. Not sure if we can add anything extra in dbt-oracle.

if you see this as 0 and need clarification you can also raise a question on python driver's issues page

[tmirko]

I don't see any line regarding affected rows.

My log after table creation looks like this:

  create  table tomicm.tomicm_test__dbt_tmp
  
  as
    


select 3 as id, sysdate as created_at from dual
union 
select 4 as id, sysdate as created_at from dual



  
�[0m17:23:23.743247 [debug] [Thread-1 (]: oracle adapter: SQL status: OK in 0.3298184871673584 seconds
�[0m17:23:23.761792 [debug] [Thread-1 (]: oracle adapter: Using oracle connection "model.poc_dbt.tomicm_test".

[aosingh]

@Mirko-T

What is the installation output of the following command ?

pip install git+https://github.com/oracle/dbt-oracle.git@debug/rowcount

And the following ?

which dbt

Are you working with a python virtual environment ? I am trying to understand if it is the correct environment where we are installing dbt-oracle and invoking dbt cli from

I will also add this log line in the next release version of dbt-oracle which will released on PyPI soon.

[tmirko]

On first command I get a bunch of Requirement already satisfied messages. On second command I get /c/Users//Miniconda3/envs/dbtpoc/Scripts/dbt, I'm using Conda virtual environment.

If you need more info from my side we can perhaps schedule a debugging call.

[aosingh]

@Mirko-T

Not sure, if the package gets installed correctly from a git branch in your conda environment

The first release cut v1.3.2rc1 is out. You can also test the log statement using this version.

pip install dbt-oracle==1.3.2rc1

Let me know you feedback