test: fake email analyzer tests now run offline in a test environment

Signed-off-by: Carl Flottmann <carl.flottmann@oracle.com>

Author: art1f1c3R

src/macaron/malware_analyzer/pypi_heuristics/metadata/fake_email.py

@@ -133,7 +133,7 @@ def analyze(self, pypi_package_json: PyPIPackageJsonAsset) -> tuple[HeuristicRes
                     continue
 
                 logger.debug("Email %s normalized to %s", email, email_info.normalized)
-                detail_info["valid_emails"].append(email)
+                detail_info["valid_emails"].append(email_info.normalized)
                 # Optimistic, so if there exists a valid email, we will pass this heuristic
                 result = HeuristicResult.PASS
 

tests/malware_analyzer/pypi/test_fake_email.py

@@ -4,7 +4,7 @@
 """Tests for the FakeEmailAnalyzer heuristic."""
 
 
-from unittest.mock import MagicMock
+from unittest.mock import MagicMock, patch
 
 import pytest
 
@@ -19,6 +19,7 @@ def analyzer_() -> FakeEmailAnalyzer:
     return FakeEmailAnalyzer()
 
 
+@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_missing_info(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test when JSON 'info' key is missing in the PyPI data (should error).
 
@@ -34,6 +35,7 @@ def test_missing_info(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer)
         analyzer.analyze(pypi_package_json)
 
 
+@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_no_emails_present(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test when no author_email or maintainer_email is present (should skip).
 
@@ -49,6 +51,7 @@ def test_no_emails_present(pypi_package_json: MagicMock, analyzer: FakeEmailAnal
     assert result == HeuristicResult.SKIP
 
 
+@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_non_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test with a non-parsable email address (should fail).
 
@@ -70,32 +73,9 @@ def test_non_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) ->
     assert "also not an email" in info["non_emails"]
 
 
-def test_invalid_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
-    """Test with an invalid email address that doesn't accept mail (should fail).
-
-    Parameters
-    ----------
-    pypi_package_json: MagicMock
-        The PyPIPackageJsonAsset MagicMock fixture.
-    analyzer: FakeEmailAnalyzer
-        An initialized FakeEmailAnalyzer instance.
-    """
-    pypi_package_json.package_json = {
-        "info": {"author_email": "user@example.com", "maintainer_email": "other@example.com"}
-    }
-
-    result, info = analyzer.analyze(pypi_package_json)
-    assert result == HeuristicResult.FAIL
-
-    # assert types (for mypy)
-    assert isinstance(info["invalid_emails"], list)
-
-    assert "user@example.com" in info["invalid_emails"]
-    assert "other@example.com" in info["invalid_emails"]
-
-
+@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_valid_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
-    """Test with valid email address that does accept mail (should pass).
+    """Test with valid email address format (should pass).
 
     Parameters
     ----------
@@ -107,16 +87,16 @@ def test_valid_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer)
     # TODO: change this to use a test domain instead of turning off deliverability
     analyzer.check_deliverability = False
     pypi_package_json.package_json = {
-        "info": {"author_email": "user@example.net", "maintainer_email": "other@example.net"}
+        "info": {"author_email": "user@example.test", "maintainer_email": "other@example.test"}
     }
     result, info = analyzer.analyze(pypi_package_json)
     assert result == HeuristicResult.PASS
 
     # assert types (for mypy)
     assert isinstance(info["valid_emails"], list)
 
-    assert "user@example.net" in info["valid_emails"]
-    assert "other@example.net" in info["valid_emails"]
+    assert "user@example.test" in info["valid_emails"]
+    assert "other@example.test" in info["valid_emails"]
 
 
 def test_get_emails(analyzer: FakeEmailAnalyzer) -> None: