Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling a check #133

Closed
2 tasks
behnazh-w opened this issue Mar 30, 2023 · 2 comments · Fixed by #254
Closed
2 tasks

Allow disabling a check #133

behnazh-w opened this issue Mar 30, 2023 · 2 comments · Fixed by #254
Assignees
@tromai
Labels
checks The issues related to Macaron checks feature A new feature request
Milestone
Allow running che...

Comments

@behnazh-w
Copy link
Member

behnazh-w commented Mar 30, 2023 •
edited
Loading

  • We need to allow a list of checks to be disabled from the CLI and handle it properly in the report.
  • Add an option to disable all the default checks.
@behnazh-w behnazh-w added the feature A new feature request label Mar 30, 2023
@tromai
Copy link
Member

tromai commented Apr 26, 2023

By default checks do you mean the current checks that currently come along with Macaron (e.g. build_as_code)?

@behnazh-w
Copy link
Member Author

By default checks do you mean the current checks that currently come along with Macaron (e.g. build_as_code)?

Yes. In future when we allow loading external checks this would be useful.

@tromai tromai mentioned this issue Apr 27, 2023
Closed
@tromai tromai linked a pull request Apr 27, 2023 that will close this issue
chore: allow disabling checks #191
Closed
@tromai tromai mentioned this issue May 29, 2023
Merged
@tromai tromai added the checks The issues related to Macaron checks label Aug 22, 2023
@tromai tromai linked a pull request Aug 22, 2023 that will close this issue
feat: add exclude and include check in ini config #254
Merged
@tromai tromai removed a link to a pull request Aug 22, 2023
chore: allow disabling checks #191
Closed
@tromai tromai closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tromai tromai

Labels
checks The issues related to Macaron checks feature A new feature request
Projects
None yet
Milestone
Allow running checks to be configurable
Development

Successfully merging a pull request may close this issue.

feat: add exclude and include check in ini config oracle/macaron
2 participants
@behnazh-w @tromai