Skip to content

Commit cefaa8b

Browse files
committed
Merge branch 'wdt-902' into 'main'
Fixing tools to detect when logging is not properly configured See merge request weblogic-cloud/weblogic-deploy-tooling!1712
2 parents ba67a98 + 0fd0e70 commit cefaa8b

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

core/src/main/python/wlsdeploy/util/tool_main.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from oracle.weblogic.deploy.logging import WLSDeployLoggingConfig
1717
from oracle.weblogic.deploy.logging import WLSDeployLogEndHandler
1818
from oracle.weblogic.deploy.util import CLAException
19+
from oracle.weblogic.deploy.util import ExitCode
1920
from oracle.weblogic.deploy.util import WebLogicDeployToolingVersion
2021
from oracle.weblogic.deploy.util import WLSDeployExit
2122
from oracle.weblogic.deploy.util import WLSDeployContext
@@ -36,6 +37,8 @@
3637
_os_arch = JSystem.getProperty('os.arch')
3738
_os_version = JSystem.getProperty('os.version')
3839

40+
_wdt_log_config_class_name = 'oracle.weblogic.deploy.logging.WLSDeployLoggingConfig'
41+
3942
def run_tool(main, process_args, args, program_name, class_name, logger):
4043
"""
4144
The standardized entry point into each tool.
@@ -49,6 +52,8 @@ def run_tool(main, process_args, args, program_name, class_name, logger):
4952
"""
5053
_method_name = 'main'
5154

55+
__assertWebLogicDeployToolingLoggingIsConfigured(program_name)
56+
5257
WebLogicDeployToolingVersion.logVersionInfo(program_name)
5358
WLSDeployLoggingConfig.logLoggingDirectory(program_name)
5459
logger.info('WLSDPLY-20043', args[0], _java_version, __format_os_version(),
@@ -87,6 +92,22 @@ def run_tool(main, process_args, args, program_name, class_name, logger):
8792
cla_helper.clean_up_temp_files()
8893
__exit_tool(model_context_obj, exit_code)
8994

95+
def __assertWebLogicDeployToolingLoggingIsConfigured(program_name):
96+
log_config_class_name = JSystem.getProperty('java.util.logging.config.class')
97+
98+
err_message = None
99+
if log_config_class_name is None:
100+
err_message = 'The WebLogic Deploy Tooling logging configuration class was not defined...%s will exit' \
101+
% program_name
102+
elif str_helper.to_string(log_config_class_name) != _wdt_log_config_class_name:
103+
err_message = 'The WebLogic Deploy Tooling logging configuration class was overridden with %s...%s will exit' \
104+
% (log_config_class_name, program_name)
105+
106+
if err_message is not None:
107+
JSystem.err.println(err_message)
108+
JSystem.exit(ExitCode.ERROR)
109+
110+
90111
def __format_os_version():
91112
return '%s %s (%s)' % (_os_name, _os_version, _os_arch)
92113

installer/src/main/bin/discoverDomain.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ usage() {
5050
echo " -ssh_private_key_pass_env <ssh_private_key_pass_env> | -ssh_private_key_pass_file <ssh_private_key_pass_file> | -ssh_private_key_pass_prompt"
5151
echo " ]"
5252
echo " [ -discover_passwords"
53-
echo " -passphrase_env <passphrase_env> | -passphrase_file <passphrase_file> | -passphrase_prompt"
54-
echo " ]"
53+
echo " -passphrase_env <passphrase_env> | -passphrase_file <passphrase_file> | -passphrase_prompt"
54+
echo " ]"
5555
echo " [ -discover_security_provider_data <discover_security_provider_scope>"
5656
echo " -passphrase_env <passphrase_env> | -passphrase_file <passphrase_file> | -passphrase_prompt"
57-
echo " ]"
57+
echo " ]"
5858
echo " [ -discover_opss_wallet"
5959
echo " [-opss_wallet_passphrase_env <opss_wallet_passphrase_env> | -opss_wallet_passphrase_file <opss_wallet_passphrase_file>]"
6060
echo " -passphrase_env <passphrase_env> | -passphrase_file <passphrase_file> | -passphrase_prompt"

0 commit comments

Comments
 (0)