You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Go→C# translation rules nested under Spec & Lineage as sub-bullets
Review Notes
The Internal methods: no default parameters (including CancellationToken); prefer overloads rule was flagged in fix: use Go-compatible JSON encoding for OCI manifests #348 review as potentially contradicting existing codebase patterns where internal methods do default CancellationToken. This should be discussed and resolved in the PR for this issue.
Summary
Rewrite .github/copilot-instructions.md to be more concise and add guidance learned from #346 / #348 (Go-compatible JSON serialization fix).
This was originally part of PR #348 but was split out per reviewer feedback (one logical change per PR).
Motivation
The current instructions file (130 lines, ~8.7 KB) has:
OciJsonSerializeris now the required path)Copilot Prompt Hints,Non-Goals, trailing---footer)Proposed Changes
Trim from ~130 to ~100 lines (−28%) with these specific edits:
Remove
---footer lineAdd
OciJsonSerializer(OrasProject.Oras.Serialization)JsonSerializercalls+not\u002B)Spaces not tabsreminder (editorconfig + CI super-linter enforces)No dead code— remove unreachable branches; verify with coverage(Descriptor Descriptor, byte[] Content))Condense (same content, fewer words)
Project Snapshot→Project)Review Notes
Internal methods: no default parameters (including CancellationToken); prefer overloadsrule was flagged in fix: use Go-compatible JSON encoding for OCI manifests #348 review as potentially contradicting existing codebase patterns where internal methods do defaultCancellationToken. This should be discussed and resolved in the PR for this issue.4e6176fon branchagent/fix-plus-escaping-346before being reverted from fix: use Go-compatible JSON encoding for OCI manifests #348.References