Snippet duplicates `-` when filling in a placeholder

[paaguti]

I have this simple snippet:

gitcl='git clone ${1:branch} ${2:repo} ${3:dir}'

First step when calling it:

When I start to fill in the first field, which should be -b somebranch, just after typing - I see that it is duplicated by TA:

[orbitalquark]

That is the textadept.editing.auto_enclose feature (https://orbitalquark.github.io/textadept/api.html#textadept.editing.auto_enclose).

I do find this annoying at times, but extremely helpful in others. Sounds like you've run into the former.

[paaguti]

Is there any way to disable this when inside a snippet?
BTW, I don't see - anywhere in Textadept's code or my init.lua as part of an auto_enclose.
I'm a bit puzzled...

Thx, /PA

[orbitalquark]

Textadept matches typed punctuation characters, so that's why you haven't found it:

textadept/modules/textadept/editing.lua

Lines 544 to 550 in db9e26a

	-- Enclose selected text in punctuation or auto-paired characters.
	events.connect(events.KEYPRESS, function(key)
	if not M.auto_enclose or buffer.selection_empty or not key:find('^%p$') then return end
	if ui.command_entry.active then return end
	M.enclose(key, M.auto_pairs[key] or key, true)
	return true -- prevent typing
	end, 1)

There's currently no way to disable this inside a snippet. You could perhaps connect to events.KEYPRESS with your own handler (and a priority of 1) that checks for if M.auto_enclose and not buffer.selection_empty and key:find('^%p$') and textadept.snippets.active then return true end -- halt propagation.

[paaguti]

Back to the discussion. It is confusing, because I don't see it happening outside the snippets.
From my analysis, it would be nicer to make enclosing on punctuation an option.
Just as M.auto_enclose

See #594

WDYT?

In my perception, it would be much nicer to just include the punctuation signs you want in your auto_pairs. Maybe
a bit cumbersome, but more consistent.

PS: the default value could be true to make the behaviour more consistent with the current.

[orbitalquark]

So outside of snippets, when you select a word and type -, the word is not enclosed in -?

I'm thinking of making my suggestion the default, where textadept.snippets.active is part of the conditional. I've only really run into unexpected wrapping while snippets are active, so this is probably an okay compromise. Is that okay with you? I'd prefer not to add another option, especially considering brace characters are punctuation and your option would exclude them, which could be confusing.

[paaguti]

Look at my PR again, please. I don't like to touch anything that is working for other people. So, yes, another customisation option, which leaves things as is for people who are comfortable with the current way and which would allow other people like me to take a greater control... at least at the beginning and then poll the users, to see how many people read the manual (not me ;-) ) and found the option so useful that they adopted it.

[orbitalquark]

Per discussion in that PR, fixed in eae67d4.