Fix potential overflow issue (#521)

0xh3rman · web-flow · commit 4427688c5b57 · 2024-11-19T15:34:04.000Z
diff --git a/rust-sdk/core/src/math/tick_array.rs b/rust-sdk/core/src/math/tick_array.rs
@@ -30,8 +30,8 @@ impl<const SIZE: usize> TickArraySequence<SIZE> {
         for i in 0..tick_arrays.len() - 1 {
             let current_start_tick_index = start_tick_index(&tick_arrays[i]);
             let next_start_tick_index = start_tick_index(&tick_arrays[i + 1]);
-            if next_start_tick_index - current_start_tick_index != required_tick_array_spacing
-                && next_start_tick_index != <i32>::MAX
+            if next_start_tick_index != <i32>::MAX
+                && next_start_tick_index - current_start_tick_index != required_tick_array_spacing
             {
                 return Err(TICK_ARRAY_NOT_EVENLY_SPACED);
             }

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ impl<const SIZE: usize> TickArraySequence<SIZE> {`
`30`	`30`	`for i in 0..tick_arrays.len() - 1 {`
`31`	`31`	`let current_start_tick_index = start_tick_index(&tick_arrays[i]);`
`32`	`32`	`let next_start_tick_index = start_tick_index(&tick_arrays[i + 1]);`
`33`		`- if next_start_tick_index - current_start_tick_index != required_tick_array_spacing`
`34`		`- && next_start_tick_index != <i32>::MAX`
	`33`	`+ if next_start_tick_index != <i32>::MAX`
	`34`	`+ && next_start_tick_index - current_start_tick_index != required_tick_array_spacing`
`35`	`35`	`{`
`36`	`36`	`return Err(TICK_ARRAY_NOT_EVENLY_SPACED);`
`37`	`37`	`}`