[AMM-110] Update tests Core SDK #1168
Open
+934
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Fix uncaught overflow issue for mul_shift_96. Add error. Fix test names in program.
calintje
requested review from
odcheung,
wjthieme and
yugure-orca
as code owners
calintje
commented
Nov 19, 2025
| let should_round_up = if let Some(round_up) = round_up { | ||
| round_up && remainder > 0 | ||
| } else { | ||
| remainder >= tick_spacing_i32 / 2 |
Contributor
Author
There was a problem hiding this comment.
Previously, with tick_spacing: 1 and round_up: None, should_round_up would evaluate to true: remainder = 0 and 1_i32 / 2 = 0.
This would result in adding +1 to the result in the if statement below.
calintje
commented
Nov 19, 2025
|
|
||
| fn mul_shift_96(n0: u128, n1: u128) -> u128 { | ||
| let mul: U256 = (<U256>::from(n0) * <U256>::from(n1)) >> 96; | ||
| mul.as_u128() |
Contributor
Author
There was a problem hiding this comment.
ethnum's as_u128() simply takes the lower 128 bits of the u256 and casts that into a u128 without checking the content of the upper 128 bits: https://docs.rs/ethnum/1.5.2/src/ethnum/uint.rs.html#241-244
The program's u256 implementation implements this check here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tick.rsget_initializable_tick_indexfor ts1mul_shift_96after casting tou128WIP