[Bug]: Preloaded options leak into search results in 2.6.1 (regression from #998)

[mmarton]

Bug description

Hi, after 2.6.1 symfony-ux-autocomplete with lazy loading broke for me, claude helped me put together a reproducer: https://github.com/mmarton/tomselect-2.6.1-bug-repro

AI explanation below:

 Root cause: PR #998 ("losing preloaded options after search") in Tom Select 2.6.1 added this block to src/plugins/virtual_scroll/plugin.ts:

  if (!loading_more && !default_values_loaded) {
      default_values_loaded = true;
      if (self.lastValue === '') {
          default_values = Object.keys(self.options);  // ← captures ALL preloaded keys
          default_pagination = pagination[''];
      }
  }

  Why this breaks ux-autocomplete's "lazy + filter" flow:

  The virtual_scroll plugin already had a clearFilter used between loads:
  const clearFilter = (option, value) =>
      self.items.indexOf(value) >= 0 || default_values.indexOf(value) >= 0;
  This keeps any option whose key is in default_values.
  
  - 2.6.0: default_values was set only on initialize → contains only static <option> keys (empty for a lazy entity field). When the user types, clearOptions(clearFilter) clears the preloaded
  results, then the server's filtered results arrive → dropdown shows only the matches. ✅
  - 2.6.1: after the initial preload, default_values is overwritten with the keys of every preloaded option. Now clearFilter keeps all of them during search. The newly loaded filtered results
  are merged on top, and Symfony UX uses score: () => () => 1 (server-side filtering, no client filter). Result: every preloaded item plus the server-filtered ones are displayed regardless of 
  the query. ❌

Expected behavior

same as in 2.6.0, filtering shows only the relevant results

Steps to reproduce

1. checkout my repo
2. run it
   ...
   X. See error

Additional context

not relevant, but

• OS:linux mint 22.3
• Browser firefox
• Version 151
• Device: laptop

[mmarton]

@NicolasCARPi @Chris53897
#1039

[NicolasCARPi]

@mmarton does this patch fixes the issue on your side? #1042

[Chris53897]

As this is loaded via symfony/asset-mapper this looks like this.

@NicolasCARPi Thanks for having a look. Is there a way we can get the complete code (for easy copy-pasting) to test this?
I guess otherwise this need to be removed from asset-mapper and loaded manually to test your PR.

[NicolasCARPi]

You can do this:

git clone https://github.com/HSAIG/tom-select -b fix/virtual-scroll-preloaded-options-bleeding-into-search
cd tom-select
npm i
npm run build

You'll then have the built files in dist/.