Commit 89d5031
committed
bitmap 3D PFP: apply 4 patterns lifted from THREE-JS-NIPPLEJS-REFERENCES
Apply the tier-1 findings from the curated repo list:
1. Hubs-Foundation/hubs -- nipplejs hardcodes `z-index: 999` on its
rendered UI elements as an inline style; this steals clicks from
any modal/dialog/overlay layered above the canvas. Mirror Hubs'
workaround: `el.style.removeProperty('z-index')` immediately after
each create(). Helper `stripNippleZIndex(mgr)` factored so both
sticks get it.
2. rune/rune -- nipplejs issue #64: a touchcancel (system gesture,
incoming call, alert dialog) can swallow the touchend and leave
the stick partially active. Cached vector freezes, camera keeps
moving. Hook document.touchcancel to zero state AND
destroy+recreate both sticks. More robust than relying on the
visibilitychange path alone.
3. needle-tools/needle-engine-samples -- the asymmetric static-left /
dynamic-right pattern. Movement stick stays at fixed position
(muscle memory: walking is what the brain does on autopilot).
Look stick now `mode: 'dynamic'` -- joystick appears under the
thumb anywhere in the right zone. Mirrors console FPS ergonomics
(left analogue is fixed by the controller body; right analogue is
the active-aim input).
4. runeharlyk/SpotMicroESP32-Leika -- module-scope lifecycle pattern.
Already in place structurally: our init / destroy live in the
render-loop closure (a function-level scope, NOT in Angular's
class-method lifecycle), so the framework's CD can't lose track
of them. No code change needed; documenting the alignment here
so a future refactor doesn't reintroduce the anti-pattern.
Source list: /Users/johanneshoppe/Work/ordpool/THREE-JS-NIPPLEJS-REFERENCES.md1 parent ac818d3 commit 89d5031
1 file changed
Lines changed: 38 additions & 5 deletions
File tree
- frontend/src/app/components/_ordpool/digital-artifact-viewer/bitmap-viewer
Lines changed: 38 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
530 | 530 | | |
531 | 531 | | |
532 | 532 | | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
533 | 545 | | |
534 | 546 | | |
535 | 547 | | |
536 | | - | |
537 | | - | |
| 548 | + | |
538 | 549 | | |
539 | 550 | | |
540 | 551 | | |
541 | 552 | | |
542 | 553 | | |
543 | 554 | | |
544 | 555 | | |
| 556 | + | |
545 | 557 | | |
546 | 558 | | |
547 | 559 | | |
| |||
550 | 562 | | |
551 | 563 | | |
552 | 564 | | |
553 | | - | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
554 | 568 | | |
555 | 569 | | |
556 | | - | |
557 | | - | |
| 570 | + | |
558 | 571 | | |
559 | 572 | | |
560 | 573 | | |
| 574 | + | |
561 | 575 | | |
562 | 576 | | |
563 | 577 | | |
| |||
577 | 591 | | |
578 | 592 | | |
579 | 593 | | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
580 | 612 | | |
581 | 613 | | |
582 | 614 | | |
| |||
606 | 638 | | |
607 | 639 | | |
608 | 640 | | |
| 641 | + | |
609 | 642 | | |
610 | 643 | | |
611 | 644 | | |
| |||
0 commit comments