fixed scripted importer issue

Author: orels1

Packages/sh.orels.shaders.generator/Editor/GeneratorProjectSettings.cs

@@ -46,6 +46,20 @@ public static GeneratorProjectSettings GetOrCreateSettings()
             return settings;
         }
 
+        /// <summary>
+        /// This version of Get Settings does not create a physical asset if none exists.
+        /// This is needed for scripted importers, as creating an asset during import will cause a unity error
+        /// </summary>
+        /// <returns></returns>
+        public static GeneratorProjectSettings GetSettings()
+        {
+            var settings = AssetDatabase.LoadAssetAtPath<GeneratorProjectSettings>(SETTINGS_PATH);
+            if (settings != null) return settings;
+
+            settings = ScriptableObject.CreateInstance<GeneratorProjectSettings>();
+            return settings;
+        }
+
         public static SerializedObject GetSerializedSettings()
         {
             return new SerializedObject(GetOrCreateSettings());

Packages/sh.orels.shaders.generator/Editor/ShaderDefinitionImporter.cs

@@ -27,7 +27,7 @@ public class ShaderDefinitionImporter : ScriptedImporter
         #region Serialized Fields
 
         public bool debugBuild;
-        private bool DebugBuild => debugBuild || GeneratorProjectSettings.GetOrCreateSettings().forceDebugBuilds;
+        private bool DebugBuild => debugBuild || GeneratorProjectSettings.GetSettings().forceDebugBuilds;
         // Cached version of the debug flag to avoid constant asset pinging
         private bool _isDebugBuild;
 
@@ -80,12 +80,12 @@ public ShaderError(ShaderBlock block, int line, string file, string message, str
 
         private List<ShaderBlock> _builtInBlocks;
 
-        private List<ModuleRemap> UserModuleRemaps => GeneratorProjectSettings.GetOrCreateSettings().userModuleRemaps;
+        private List<ModuleRemap> UserModuleRemaps => GeneratorProjectSettings.GetSettings().userModuleRemaps;
         // Cached version of the user module remaps to avoid constant asset pinging
         private List<ModuleRemap> _userModuleRemaps;
 
         // Some blocks need to be included in all shaders
-        private List<string> AlwaysIncludedBlockSources => GeneratorProjectSettings.GetOrCreateSettings().alwaysIncludedBlocks;
+        private List<string> AlwaysIncludedBlockSources => GeneratorProjectSettings.GetSettings().alwaysIncludedBlocks;
 
         private List<ShaderBlock> AlwaysIncludedBlocks
         {
@@ -113,7 +113,7 @@ private List<ShaderBlock> AlwaysIncludedBlocks
             }
         }
 
-        private string DefaultLightingModel => GeneratorProjectSettings.GetOrCreateSettings().defaultLightingModel;
+        private string DefaultLightingModel => GeneratorProjectSettings.GetSettings().defaultLightingModel;
 
         #endregion
 

Packages/sh.orels.shaders.generator/package.json

@@ -2,7 +2,7 @@
   "name": "sh.orels.shaders.generator",
   "displayName": "ORL Shader Generator",
   "description": "A template-based shader generator utilizing scripted importers",
-  "version": "7.0.0-dev.4",
+  "version": "7.0.0-dev.5",
   "unity": "2019.4",
   "author": {
     "name": "orels1",

Packages/sh.orels.shaders.inspector/package.json

@@ -2,7 +2,7 @@
   "name": "sh.orels.shaders.inspector",
   "displayName": "ORL Shader Inspector",
   "description": "A simple property-based shader inspector with extension support",
-  "version": "7.0.0-dev.4",
+  "version": "7.0.0-dev.5",
   "unity": "2019.4",
   "author": {
     "name": "orels1",

Packages/sh.orels.shaders/package.json

@@ -2,7 +2,7 @@
   "name": "sh.orels.shaders",
   "displayName": "ORL Shaders",
   "description": "PBR Unity shaders for the Built-In pipeline built with ORL Shader Generator",
-  "version": "7.0.0-dev.4",
+  "version": "7.0.0-dev.5",
   "unity": "2019.4",
   "author": {
     "name": "orels1",
@@ -18,7 +18,7 @@
   "license": "MIT",
   "type": "assets",
   "vpmDependencies": {
-    "sh.orels.shaders.generator": "^7.0.0-dev.4",
-    "sh.orels.shaders.inspector": "^7.0.0-dev.4"
+    "sh.orels.shaders.generator": "^7.0.0-dev.5",
+    "sh.orels.shaders.inspector": "^7.0.0-dev.5"
   }
 }