Improve Repo model

[orendon]

improve Repo model to reduce method complexity, also test are welcome
https://codeclimate.com/github/orendon/contrib-hub/Repo

[barisbalic]

The mixing of GH repos and CH repos is what is perverting the repo model, it's forcing you to combine the concerns of finding and creating from remote source. I dropped you an email about discussing this, I would be happy to work on it, but I think CH repos should be created for every GH repo the user has, this can be done on initial-sign in. This will greatly reduce the complexity.

The cost will be that you store repos that potentially will never be marked as needing help, but I think this is a small price to pay.

[orendon]

I completely agree, all user data should be created at once, also updated through background tasks.

Currently working on some cleanup/refactoring to improve the codebase before jumping to next exciting features, also started some sketchs for a completely new GUI, gonna send you my info so we can talk and be on the same roadmap.

I'm glad you want to help, nice! 👍

[barisbalic]

When some of my pull requests have been accepted/declined I will go ahead and refactor this. Feel free to assign it to me.

[orendon]

Agreed, controller should be re-factored so we don't have to merge repos https://github.com/orendon/contrib-hub/blob/master/app/controllers/users_controller.rb#L20-L26