Radjabov-1 : resize Vmware disk in reconfigure VM

[Berhin59]

Hello,

I have a question, i'm not a very good developer but i need to limit sizing of disk reconfiguration on vmware VM

When resizing a disk, I want to be able to add a maximum of 300GB.
And when adding a new disk, I want to be able to set a maximum size of 500GB and no more.

I was able to do this in previous versions, but now that everything has been rewritten in Ruby, I'm a little lost.

I found the files /reconfigure-vm-form/index.jsx and components/reconfigure-vm-form/disk-form-fields.js, but I'm not sure how to modify them to meet my requirements. Could someone please help me?

[kbrock]

@agrare can you take a look at this?

[agrare]

@Berhin59 I think your best bet would be to add a maxSizeInMb to the disk helper here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/javascript/components/reconfigure-vm-form/helpers/disk.js#L192-L201

export const validateDiskSize = (value, unit, minSize, minUnit) => {
  if (!Number.isNaN(value)) {
    const valueInMb = sizeInMB(value, unit);
    const minSizeInMb = sizeInMB(minSize, minUnit);
    if (valueInMb >= minSizeInMb) {
      return true;
    }   
  }
  return false;
};

[Berhin59]

Hello,

I modified this :

export const validateDiskSize = (value, unit, minSize, minUnit) => { if (!Number.isNaN(value)) { const valueInMb = sizeInMB(value, unit); const minSizeInMb = sizeInMB(minSize, minUnit); if (valueInMb >= minSizeInMb) { return true; } } return false; };

By this

`export const validateDiskSize = (value, unit, minSize, minUnit) => {
if (!Number.isNaN(value)) {
const valueInMb = sizeInMB(value, unit);
const minSizeInMb = sizeInMB(minSize, minUnit);
const maxIncreaseInMb = sizeInMB(300, 'GB');

if (valueInMb < minSizeInMb) {
  return false;
}

if (valueInMb > minSizeInMb + maxIncreaseInMb) {
  return false;
}

return true;

}
return false;
};
`

But now my evmserverd cannot start.
Is something wrong ?

Thanks,