Secret Data Analytics docs feedback

[a3s7p]

https://docs.nillion.com/build/secretVault-secretDataAnalytics/create-query

• example code in python checks for 200 OK return code, but the API actually returns 201 Created now
• "name": "Returns usernames for a given service by order of creation", seems to be wrong
• example sum schema doesn't work to store data unless the operation is set to sum in SecretVaultWrapper constructor, this is undocumented
• _id needs to be generated by the caller in TS for now; crypto.randomUUID() works for that
• in create query API, the parameter is _id (MongoDB convention I assume) but in execute query, it is id; the meaning is the same
• there is no JS/TS query create example, but there is an example for TS for executing the query

https://docs.nillion.com/build/secretVault-secretDataAnalytics/query

• TS example uses Credential type which is not defined
• /queries/execute with id in payload is not RESTful but /queries/[id]/execute would be
• maybe the TS examples should use SecretVaultWrapper.makeRequest() instead of vanilla fetch()

[a3s7p]

Additionally:

• when using "sum" operation mode, the integers turn into bigints inside the Secret Vault; this is undocumented and it leads to e.g. JSON.stringify failing on the value received from the vault
• the docs JS example of executing a query directly via the API will return the raw shares which still need to be recombined into the real value using NilQlWrapper.unify()
• it appears that @nillion/nilql has defined TS types, it should be enough to re-export those in secretvaults so the nilQL interface is typed