Update global.json to use .NET 10.0.302?

[blueheron786]

I just spent a couple of hours trying to build OrchardCore locally on Kubuntu. Turns out OrchardCore uses .NET 10.0.302. global.json points at 10.0.200, which is not compatible. (10.0.200 ships with Roslyn 5.3.0 instead of 5.6.0, which causes compile-time errors.)

Is it worth updating global.json to 10.0.302 so future new developers have a clue what version they need? I also didn't see anything in the docs, other than a mention of .NET 10.0.

[Piedone]

Sounds reasonable. Would you like to submit a contribution for this?

[blueheron786]

Yes, absolutely.

[Piedone]

Thank you!

[gvkries]

There is already a PR to fix this: #19639

@Piedone: Is it possible to configure Renovate so that we don't miss these updates? Like, if a CodeAnalysis package is updated, we might need a newer SDK version each time. Or we might have to disable automatic updates for the CodeAnalysis packages.

[Piedone]

That should be covered by mcr.microsoft.com/dotnet/sdk. Where was that updated by Renovate?

[gvkries]

#19574

550d963#diff-5baf5f9e448ad54ab25a091adee0da05d4d228481c9200518fcb1b53a65d4156R41

[Piedone]

Hmm. That should've failed the build, though, I don't understand.

[blueheron786]

Hmm. That should've failed the build, though, I don't understand.

My understanding is that the build passed because of a combination of:

1. This line in global.json: "rollForward": "latestMajor"
2. action.yml using setup-dotnet to get the very latest version of .NET available

[Piedone]

Ah, the problem is that we specify a .NET version: https://github.com/OrchardCMS/OrchardCore/blob/main/.github/actions/setup-dotnet/action.yml#L11. Because otherwise it takes global.json into account: https://github.com/actions/setup-dotnet#usage So, we should just remove the version from the action and update the .NET upgrade issue template. Something you'd consider contributing, @blueheron786?

[hishamco]

#19639

[blueheron786]

Looks like something went wrong with my initial PR; closed it and opened a new PR #19656 which seems OK so far.

[Piedone]

Thanks!