Brave browser not a modern browser?

[Paradoxum]

Describe the problem/question

Shouldn't it work in Brave?

Did you use the FAQ section?

• Yes, I have read the FAQ and I found no solution/answer there.

What you did?

...

What happens

No response

What should happen

No response

Additional information

No response

Server address

No response

Server OS

Unraid latest beta 3

Webserver

No response

PrivateBin version

privatebin/nginx-fpm-alpine:latest

Browser and version

Brave 1.82.172 (Official Build) (64-bit) Chromium: 140.0.7339.207

Local operating system and version

w111

Issue reproducibility

No, I cannot reproduce it on https://privatebin.net.

[Paradoxum]

If I click switch to https I get this:

[elrido]

For HTTPS to work, you need to enable use of TLS in your web server and provide it with a certificate - if this is a local setup, you can self-sign a certificate with your own CA and install the signing cert into your browser, so that access to your server is trusted.

On the main subject, PrivateBin uses feature detection to decide if it considers a browser as "modern". There are 3 main features necessary for a browser to pass the feature detection:

1. It needs to support the Web Crypto API (for encrypting and decrypting documents in the browser) which in some browsers requires the use of HTTPS to get enabled.
2. It needs to have support for WASM streaming (for the optional compression of the documents) - some older web servers don't yet support the WASM mimetype out of the box that is necessary for this, so you may need to manually configure this. PrivateBin does still function without this, just warn you if not supported. You can disable use of compression in your configuration.
3. It needs to support ECMA Script 6 features, as we use some of these newer JavaScript keywords in our code, such as let and const instead of the old school var declarations.

Brave is based on Chromium, so I'm pretty sure that it is fully supported by PrivateBin, but you do need to check on how to setup HTTPS in your web server in order to use it with Brave or Chrome/ium.

[rugk]

In addition see the following FAQ: https://github.com/PrivateBin/PrivateBin/wiki/FAQ#how-should-i-setup-https

Also please note the error message itself shows a link to the FAQ. Here:

PrivateBin/tpl/bootstrap.php

Lines 527 to 534 in f03f2bf

	<div id="oldnotice" role="alert" class="hidden alert alert-danger">
	<span class="glyphicon glyphicon-alert" aria-hidden="true"></span>
	<?php echo I18n::_('%s requires a modern browser to work.', I18n::_($NAME)), PHP_EOL; ?>
	<a href="https://www.mozilla.org/firefox/">Firefox</a>,
	<a href="https://www.opera.com/">Opera</a>,
	<a href="https://www.google.com/chrome">Chrome</a>…<br />
	<span class="small"><?php echo I18n::_('For more information <a href="%s">see this FAQ entry</a>.', 'https://github.com/PrivateBin/PrivateBin/wiki/FAQ#why-does-it-show-me-the-error-privatebin-requires-a-modern-browser-to-work'); ?></span>
	</div>

The real error is the HTTPS one below though, here is why it happens: https://github.com/PrivateBin/PrivateBin/wiki/FAQ#why-does-it-show-me-an-error-about-an-insecure-connection

[rugk]

Though it is strange the actual httpnotice is not used/shown? I made #1660 to clarify the code, but from I see the HTTP error message should be shown.

[elrido]

Though it is strange the actual httpnotice is not used/shown?

The current logic seems to be to show the insecurecontextnotice if it's an old browser and insecure connection and the httpnotice if it is an otherwise "modern" browser but an insecure context, which may still disable the web crypto API.

[rugk]

Yeah but if we detect "modern browser" base on the fact whether the Web crypto API is available and even modern browsers then limit it on HTTP, we have the shown case here that httpnotice basically is never shown as accessed over http every browser is "old". So we should really change that and at least in addition display the actual most important error message httpnotice to prevent the confusion here, IMHO.

[Paradoxum]

sorry for the late reply, I still never got that error to disappear in brave, but after setting up the docker more I can't get on the webui at all anyway which is an unrelated issue probably https related.