After upgrade to latest JQuery we are seeing "getFile is not a function and getAttachmentData is not a function"

[cloudscape-germany]

Describe the problem/question

JQuery errors in Web console after major version bump of Privatebin

Did you use the FAQ section?

• Yes, I have read the FAQ and I found no solution/answer there.

What you did?

1. Upgrade to latest libraries, we are uprading from a 1.x.x Privatebin version
2. Was able to remove all errors and warnings in console
3. JQuery Error remains

What happens

After creation of document/paste, on "page" where you are offered to copy the link:

If file is attached only this error:
Uncaught TypeError: jQuery.PrivateBin.AttachmentViewer.getAttachmentData is not a function

If no file is attached, these errosr:

Uncaught TypeError: jQuery.PrivateBin.AttachmentViewer.getAttachmentData is not a function
Uncaught TypeError: jQuery.PrivateBin.AttachmentViewer.getFile is not a function

What should happen

No JQuery Error in Web Development Tools

Additional information

No response

Server address

No response

Server OS

RHEL 9.6

Webserver

Nginx

PrivateBin version

2.0.3

Browser and version

Firefox

Local operating system and version

Win11

Issue reproducibility

No, I cannot reproduce it on https://privatebin.net.

[elrido]

Those functions don't exist in the current version of PrivateBin (2.0.3), so I see no way the current logic would call them. I can't reproduce this on the 2.0.3 codebase, either. Are you using some custom template that sideloads some custom javascript files or are you using some cache such as cloudflare, cloudfront or similar that still caches some old files from before the upgrade? Make sure you flush their caches (check your cloud vendors manuals) and be sure to check with different clients (different devices) to ensure it's not a caching issue on the client side.

[cloudscape-germany]

I agree, those came from our own template, which was legacy. I adapted to new function names. The old privatebin.js library function names were getFile and getAttachmentData, the new ones are in plural. getFiles and getAttachmentsData.

The method name name in getFiles.name seems to have been dropped?

[elrido]

Oh, is this because of the multi-upload? You would need to do some PR-archeology, then, to try and understand what the intent of the new functions is and how they are being used. This one might be a good starting point - seems that call now returns a list, as indicated in JSdoc block for the function. this is where the file names are read, using map to get a list of file names:
https://github.com/PrivateBin/PrivateBin/pull/1550/changes#diff-4c30f267da1a33c8d947890833316f48f2c58b89bc0ae567a469056ce98b96e5R5233

I had not assumed anyone would need to interact with that JS logic from the outside. They are public primarily for other parts of PrivateBin to interact with them and to allow for unit testing. You may find the published JSDoc useful.