Add "Share via Send" action to vault items (one-click, UI-only) #20574
babyhuey
started this conversation in
Password Manager
Replies: 1 comment
-
|
✨ Thank you for your code contribution proposal! While the Bitwarden team reviews your submission, we encourage you to check out our contribution guidelines. Please ensure that your code contribution includes a detailed description of what you would like to contribute, along with any relevant screenshots and links to existing feature requests. This information helps us gather feedback from the community and Bitwarden team members before you start writing code. To keep discussions focused, posts that do not include a proposal for a code contribution will be removed.
Thank you for contributing to Bitwarden! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I would like to propose adding a "Share via Send" action to the vault item context menu in the web, desktop, and browser-extension clients. Clicking it would open the existing Send composer pre-filled with the item's credentials, so users no longer have to copy each field by hand into a text Send.
A working branch (web, desktop, browser; all client tests green; webpack build green) is here for concrete reference: https://github.com/babyhuey/clients/tree/share-via-send
Context
Several long-standing community threads have asked for exactly this UX, most recently Send a password from vault. The canonical vault-item-sharing thread (open since 2018) is broader and architecturally fraught; this proposal is intentionally narrower.
What I am proposing (v1)
A new menu entry, "Share via Send", on the vault item action menu. Clicking it:
DisableSendpolicy (toast + bail before any credential plaintext leaves the menu).SendViewfrom the cipher's username, password, URI, and notes, with conservative defaults:The user controls the final Send. The pre-fill is a convenience layer; the data path is identical to manual copy/paste.
What I am not proposing
SendType.Textand the existing Send composer.Suggested direction (matches the working branch)
{ type: "shareViaSend"; item: C }variant on the existingVaultItemEventdiscriminated union inlibs/vault.cipherToSendTextView(cipher, options)pure helper inlibs/common/src/tools/send, unit-tested in isolation.initialView?: SendViewfield onSendFormConfig. Inaddmode,DefaultSendFormServiceroutes it throughoriginalSendViewso existing form components patch their controls without per-component changes.PendingSendDraftServicewith a caller-issued token (passed as a query param) so credential plaintext never travels through URLs and a cancelled share-via-send navigation cannot leak its draft into a later "New Send" click.SendAddEditDialogComponent.open/openDrawer. Browser navigates to the existing/add-sendroute.Total diff in the working branch: 21 files, 590 insertions. All five client app test groups (libs, browser, web, desktop, cli) and the full
test:typesstrict-mode pass.Questions for the team
areSendsAllowed(viaSendPolicyService). Should there also be a separate, narrower policy for "Disable Share via Send for org-owned items" so admins can turn off the convenience without disabling Sends entirely, or is the existing policy sufficient?Happy to adjust scope based on feedback before opening the PR.
Beta Was this translation helpful? Give feedback.
All reactions