datadog components failing

[brucex]

a lot of datadog components have recently been updated to where there's a ref in the module ?ref=tags/v1.535.3

cloudposse-terraform-components/aws-datadog-credentials@977e2f8

is this suppose to work? my terraform fails with the below

Downloading git::https://github.com/cloudposse-terraform-components/aws-account-map.git?ref=tag for iam_roles_datadog_secrets... ╷ │ Error: Failed to download module │ │ on provider-datadog.tf line 18: │ 18: module "iam_roles_datadog_secrets" { │ │ Could not download module "iam_roles_datadog_secrets" (provider-datadog.tf:18) source code from "git::https://github.com/cloudposse-terraform-components/aws-account-map.git?ref=tag": error downloading │ 'https://github.com/cloudposse-terraform-components/aws-account-map.git?ref=tag': /usr/bin/git exited with 1: error: pathspec 'tag' did not match any file(s) known to git

when i leave out tags/ and do ?ref=v1.535.3, this works

[goruha]

@brucex thanks for the bug report.
I will address it at the beginning of next week.

[goruha]

@brucex, thank you for raising this!
Your report brought to light an unusual Terraform behaviour we hadn’t encountered before.

Some time ago, Terraform inherited a bug related to / in Git ref URI.
You can read about it here hashicorp/go-getter#469
We used to have a standard to use refs prefixed with tags/ to guarantee that the reference is a tag, as tags are more consistent than branches.
Now we have relaxed the requirement until the issue is fixed.
I already updated our bats tests cloudposse/test-harness#56

Also, @Benbentwo provided a fix to the aws-datadog-credentials module cloudposse-terraform-components/aws-datadog-credentials#33.

Here is the new release https://github.com/cloudposse-terraform-components/aws-datadog-credentials/releases/tag/v1.535.3

By the end of this week, we will fix references for other components that have the same issue.

[goruha]

@brucex

Releases contains fixes for / in git ref uri:

• https://github.com/cloudposse-terraform-components/aws-managed-grafana-data-source-managed-prometheus/releases/tag/v1.535.2
• https://github.com/cloudposse-terraform-components/aws-datadog-private-location-ecs/releases/tag/v1.535.4
• https://github.com/cloudposse-terraform-components/aws-managed-grafana-data-source-loki/releases/tag/v1.535.2
• https://github.com/cloudposse-terraform-components/aws-datadog-lambda-forwarder/releases/tag/v1.535.4
• https://github.com/cloudposse-terraform-components/aws-datadog-credentials/releases/tag/v1.535.4
• https://github.com/cloudposse-terraform-components/aws-datadog-logs-archive/releases/tag/v1.535.3
• https://github.com/cloudposse-terraform-components/aws-datadog-synthetics/releases/tag/v1.535.2
• https://github.com/cloudposse-terraform-components/aws-datadog-synthetics-private-location/releases/tag/v1.535.4

Looks like we covered all cases.
Message me if you will see anything else