⚠️ we made mistakes in the evolution of moclojer cli and not testing with "real" requests

[avelino]

I need to start this discussion by apologizing for not having performed tests with simple cURL using an example mock and blindly trusting the tests.

Why am I saying this?
The code that is in the main branch and in the latest release is not working for requests

damn, I messed up badly

What will we do?

I will do a hard reset going back to the stable version and from there, evolve the code, but the first thing I'll need to implement is the workflow in github actions to run "integration" tests, cURL loop testing behaviors.

---

again I apologize for the amateur mistake I made as the project maintainer

[J0sueTM]

What do you mean by not working? It seems to be alright to me

[avelino]

example in print, config file

moclojer/test/com/moclojer/resources/moclojer.yml

Lines 2 to 31 in d8e03a0

	- endpoint:
	# Note: the method could be omitted because GET is the default
	method: GET
	path: /hello/:username
	response:
	# Note: the status could be omitted because 200 is the default
	status: 200
	headers:
	Content-Type: application/json
	# Note: the body will receive the value passed in the url using the
	# :username placeholder
	body: >
	{
	"hello": "{{path-params.username}}!"
	}
	# This mock register route: GET /hello/world
	- endpoint:
	# Note: the method could be omitted because GET is the default
	method: GET
	path: /hello-world
	response:
	# Note: the status could be omitted because 200 is the default
	status: 200
	headers:
	Content-Type: application/json
	body: |
	{
	"hello": "Hello, World!"
	}

[Felipe-gsilva]

@avelino it is strange, because the curl with -i (which includes the entire header) instead of -I (uppercase I) seems to find the url, even though it is returning a strange parsing error

this one, to be precise:

java.lang.IllegalArgumentException: No implementation of method: :write-body-to-stream of protocol: #'ring.core.protocols/StreamableResponseBody found for class: clojure.lang.PersistentArrayMap

[Felipe-gsilva]

maybe the response is retrieving this error body, which does not appear on the -I request at all, can you try the -i curl and see if it returns the same error?

[avelino]

yep, initial PR #312

[Felipe-gsilva]

@avelino are all mocks not working or only a specific one? can you specify this issue so I can check it here pls?

[avelino]

if you notice the comment I made above you will see that the requests "are not arriving", probably it's some problem with middlewares, I haven't had time to debug it yet

[Felipe-gsilva]

oh, ok, I see, thanks

[avelino]

@moclojer/contributors Please review this PR very carefully
#312

[avelino]

I decided not to do the revert but instead understand the problem and fix it
Integration tests were written with curl to ensure the expected behavior in each request of an example mock (yaml)