[GSoC] WiFi Login Pages Modernization #1244
Replies: 5 comments 4 replies
-
|
Hi @nemesifier , actually i am working on login page proposal. I make a repo of structure of client/component and I am thinking of turning .js files to .jsx file for easy code read and future upgrade . Are you open for it or I keep it to .js ?? |
Beta Was this translation helpful? Give feedback.
-
|
Hi, i am interested in working on this, what all changes do you mean by modernisation, I already have a pr for upgrading to react 18, should we also convert our class based cmponents to functional components and all other migration from the legacy react code to the new code format? |
Beta Was this translation helpful? Give feedback.
-
|
Hi Iam Munesh Kumar. I want to contribute to this GSoC 26 project; I have a strong foundation in React.js and Node.js. I start with this one [feature] Automate generation of client/test-translation.json from .po files #902. Guide me more about this feature. Which library can I use gettext-parser or po2json for this one? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @nemesifier ! 1). The Status component manages authentication, usage monitoring, ui rendering, subscription period logic & session fetching. All these concerns together makes testing difficult. 2). Refactor componentDidMount : componentDidMount logic is quite confusing as it handles token validation, captive portal login, logout, redirect logic and cookie logic. The nested checks makes it harder to debug and may introduce bugs. 3). Repeated RADIUS session requests is called at multiple times, and current structure makes it harder to ensure consistency. 4). Component Modularity : The status.js file currently mixes ui rendering logic with session management and networking and even in captive portal sync logic. This also increases difficulty while testing individual components. ==My initial approach for the execution== 1). Extract helper functions for better flow Does this approach align with the issue, or shall I work in a different direction? |
Beta Was this translation helpful? Give feedback.
-
|
Hey @nemesifier , To improve maintainability and allow for independent unit testing, I propose moving from a monolithic structure to a decentralized Service-Hook-Component approach:
Does this "Service-Hook-Component" architecture align with the project's long-term maintainability goals? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Official thread for this GSoC idea, ask questions and announce your interest here.
Beta Was this translation helpful? Give feedback.
All reactions