Conventional Commits Now Required for All PRs #26207
tdcmeehan
announced in
Announcement
Replies: 1 comment
-
I also wanted to add that reviewers no longer need to ask submitters to squash commits, this will now be done automatically, since the commit message is based on the PR title. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
At the TSC meeting we decided to unify our commit message format by following conventional commits. With #26122 merged, all PR titles must now follow this format, which will be validated automatically by an accompanying GitHub Action.
PR Title Format:
<type>[(scope)]: <description>
Examples:
For more details, including the list of types and scopes, see the documentation: https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#conventional-commits
This also means that large, multi-commit PRs are deprecated in favor of smaller PRs that affect singular modules. Large PRs are still welcome as a way to give reviewers broader context, but in order to merge, the scope should be appropriate, which means large PRs may have to be broken down into smaller ones. To reflect this, the default action to close the pull request is now Squash instead of Merge.
For now, the Github Action is advisory, but everyone should try to get it to pass on their PRs starting now. After some period of time, we can make it mandatory.
Reach out if you have any questions!
Beta Was this translation helpful? Give feedback.
All reactions