Bug Fix: Remove Duplicate aria-sort Declaration in TreeTableHeader Component #4559
Unanswered
NADIRATIF
asked this question in
PrimeReact
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi PrimeReact team,
I'd like to propose a bug fix for the TreeTableHeader component that addresses a duplicate property declaration issue.
Issue Description:
The
TreeTableHeader.jscomponent currently has a duplicate'aria-sort'property declaration on lines 325 and 331, causing ESLint "Duplicate declaration" errors. This occurs because both an inlineariaSortvariable and theariaSortDatafrom thegetAriaSort()function are being used for the same ARIA attribute.Current Problematic Code:
Proposed Solution:
Remove the duplicate inline declaration and keep only the
ariaSortDataversion which:getAriaSort()functionBenefits:
Files to be modified:
components/lib/treetable/TreeTableHeader.js(remove duplicate property and unused variable)This is a straightforward bug fix that improves code quality while maintaining full backward compatibility. I'm ready to submit a PR once I get approval to proceed.
Could you please review this proposal and let me know if you'd like me to move forward with the fix?
Best regards.
Beta Was this translation helpful? Give feedback.
All reactions