Event destination on startup

[afgTheCat]

Hi,

how can I make sure that event webhooks are created on startup? I was under the assumption, that specifying the following env vars would create a webhook called file_upload_hook:

services:
  s3:
    image: rustfs/rustfs:latest
    ports:
      - "9000:9000"
      - "9001:9001"
    environment:
      RUSTFS_ACCESS_KEY: rustfsadmin
      RUSTFS_SECRET_KEY: rustfspassword
      RUSTFS_CONSOLE_ENABLE: true
      RUSTFS_NOTIFY_WEBHOOK_ENABLE_file_upload_hook: "on"
      RUSTFS_NOTIFY_WEBHOOK_ENDPOINT_file_upload_hook: "http://something.something"
    volumes:
      - rustfs-data:/data
    command: ["--console-enable", "/data"]

volumes:
  rustfs-data:

On a semi related note (since I have no idea about the internal architecture), on the latest release, the env vars don't seem to be used. For me, rustfs builds and runs when applying the following patch (just removes the env vars + the get_valid_env_fields method from the notify::factory::TargetFactory trait):

diff --git a/crates/config/src/notify/webhook.rs b/crates/config/src/notify/webhook.rs
index 8481d7e1..fa338ff7 100644
--- a/crates/config/src/notify/webhook.rs
+++ b/crates/config/src/notify/webhook.rs
@@ -23,22 +23,3 @@ pub const NOTIFY_WEBHOOK_KEYS: &[&str] = &[
     crate::WEBHOOK_CLIENT_KEY,
     crate::COMMENT_KEY,
 ];
-
-// Webhook Environment Variables
-pub const ENV_NOTIFY_WEBHOOK_ENABLE: &str = "RUSTFS_NOTIFY_WEBHOOK_ENABLE";
-pub const ENV_NOTIFY_WEBHOOK_ENDPOINT: &str = "RUSTFS_NOTIFY_WEBHOOK_ENDPOINT";
-pub const ENV_NOTIFY_WEBHOOK_AUTH_TOKEN: &str = "RUSTFS_NOTIFY_WEBHOOK_AUTH_TOKEN";
-pub const ENV_NOTIFY_WEBHOOK_QUEUE_LIMIT: &str = "RUSTFS_NOTIFY_WEBHOOK_QUEUE_LIMIT";
-pub const ENV_NOTIFY_WEBHOOK_QUEUE_DIR: &str = "RUSTFS_NOTIFY_WEBHOOK_QUEUE_DIR";
-pub const ENV_NOTIFY_WEBHOOK_CLIENT_CERT: &str = "RUSTFS_NOTIFY_WEBHOOK_CLIENT_CERT";
-pub const ENV_NOTIFY_WEBHOOK_CLIENT_KEY: &str = "RUSTFS_NOTIFY_WEBHOOK_CLIENT_KEY";
-
-pub const ENV_NOTIFY_WEBHOOK_KEYS: &[&str; 7] = &[
-    ENV_NOTIFY_WEBHOOK_ENABLE,
-    ENV_NOTIFY_WEBHOOK_ENDPOINT,
-    ENV_NOTIFY_WEBHOOK_AUTH_TOKEN,
-    ENV_NOTIFY_WEBHOOK_QUEUE_LIMIT,
-    ENV_NOTIFY_WEBHOOK_QUEUE_DIR,
-    ENV_NOTIFY_WEBHOOK_CLIENT_CERT,
-    ENV_NOTIFY_WEBHOOK_CLIENT_KEY,
-];
diff --git a/crates/notify/src/factory.rs b/crates/notify/src/factory.rs
index c324bf2f..a0b4dbaf 100644
--- a/crates/notify/src/factory.rs
+++ b/crates/notify/src/factory.rs
@@ -16,7 +16,7 @@ use crate::Event;
 use async_trait::async_trait;
 use hashbrown::HashSet;
 use rumqttc::QoS;
-use rustfs_config::notify::{ENV_NOTIFY_MQTT_KEYS, ENV_NOTIFY_WEBHOOK_KEYS, NOTIFY_MQTT_KEYS, NOTIFY_WEBHOOK_KEYS};
+use rustfs_config::notify::{NOTIFY_MQTT_KEYS, NOTIFY_WEBHOOK_KEYS};
 use rustfs_config::{
     DEFAULT_LIMIT, EVENT_DEFAULT_DIR, MQTT_BROKER, MQTT_KEEP_ALIVE_INTERVAL, MQTT_PASSWORD, MQTT_QOS, MQTT_QUEUE_DIR,
     MQTT_QUEUE_LIMIT, MQTT_RECONNECT_INTERVAL, MQTT_TOPIC, MQTT_USERNAME, WEBHOOK_AUTH_TOKEN, WEBHOOK_CLIENT_CERT,
@@ -45,9 +45,9 @@ pub trait TargetFactory: Send + Sync {
     /// This is used to filter environment variables.
     fn get_valid_fields(&self) -> HashSet<String>;
 
-    /// Returns a set of valid configuration env field names for this target type.
-    /// This is used to filter environment variables.
-    fn get_valid_env_fields(&self) -> HashSet<String>;
+    // /// Returns a set of valid configuration env field names for this target type.
+    // /// This is used to filter environment variables.
+    // fn get_valid_env_fields(&self) -> HashSet<String>;
 }
 
 /// Factory for creating Webhook targets
@@ -113,9 +113,9 @@ impl TargetFactory for WebhookTargetFactory {
         NOTIFY_WEBHOOK_KEYS.iter().map(|s| s.to_string()).collect()
     }
 
-    fn get_valid_env_fields(&self) -> HashSet<String> {
-        ENV_NOTIFY_WEBHOOK_KEYS.iter().map(|s| s.to_string()).collect()
-    }
+    // fn get_valid_env_fields(&self) -> HashSet<String> {
+    //     ENV_NOTIFY_WEBHOOK_KEYS.iter().map(|s| s.to_string()).collect()
+    // }
 }
 
 /// Factory for creating MQTT targets
@@ -218,7 +218,7 @@ impl TargetFactory for MQTTTargetFactory {
         NOTIFY_MQTT_KEYS.iter().map(|s| s.to_string()).collect()
     }
 
-    fn get_valid_env_fields(&self) -> HashSet<String> {
-        ENV_NOTIFY_MQTT_KEYS.iter().map(|s| s.to_string()).collect()
-    }
+    // fn get_valid_env_fields(&self) -> HashSet<String> {
+    //     ENV_NOTIFY_MQTT_KEYS.iter().map(|s| s.to_string()).collect()
+    // }
 }

which leads me to believe that the env vars are not checked? Just grepping the codebase afterwards for ENV_NOTIFY_WEBHOOK_ENABLED returns nothing. Could these be related?

Many thanks in advance!

[loverustfs]

@houseme ,

Could you help @afgTheCat ?

[houseme]

Thanks for your feedback, please set 'RUSTFS_NOTIFY_WEBHOOK_ENABLE_file_upload_hook' to 'RUSTFS_NOTIFY_WEBHOOK_ENABLE_FileUploadHook', and change 'file_upload_hook' to 'FileUploadHook', I hope it helps! @afgTheCat

[houseme]

#1892 (comment)