Release 5.4.0 & GitHub Actions #1554
Replies: 17 comments
|
The PR is ready (#658) to ditch both Travis & AppVeyor because GitHub Actions can handle windows server too. |
|
I really like GitHub Actions. We are using it to publish the npm package too. |
|
Hi Jérémy,
just let me know what I should do exactly :)
…On Mon, Nov 23, 2020 at 10:04 AM Jérémy Benoist ***@***.***> wrote:
The PR is ready (serverless-heaven/serverless-webpack#658
<#658>) to
ditch both Travis & AppVeyor because GitHub Actions can handle windows
server too.
Let me know what do you think and then @HyperBrain
<https://github.com/HyperBrain> will need to update requirement for PR to
be merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/19/comments/1>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXRIYEGDTGFIK2SQXMDSRIQSPANCNFSM4T5HC5OA>
.
|
|
Hi Frank, You should update the required status checks in the branch protection rules here: https://github.com/serverless-heaven/serverless-webpack/settings/branches Untick appveyor & travis and tick Thanks! |
|
Hmmm.... I only see AppVeyor and Travis but no Linter & Tests
…On Wed, Nov 25, 2020 at 8:43 AM Jérémy Benoist ***@***.***> wrote:
Hi Frank,
You should update the required status checks in the branch protection
rules here:
https://github.com/serverless-heaven/serverless-webpack/settings/branches
Untick appveyor & travis and tick Linter & Tests.
And it should be fine :)
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/19/comments/4>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXSYDNN3I33YPD5YXRLSRSYQPANCNFSM4T5HC5OA>
.
|
|
[image: image.png]
…On Mon, Nov 30, 2020 at 8:56 PM Frank Schmid ***@***.***> wrote:
Hmmm.... I only see AppVeyor and Travis but no Linter & Tests
On Wed, Nov 25, 2020 at 8:43 AM Jérémy Benoist ***@***.***>
wrote:
> Hi Frank,
>
> You should update the required status checks in the branch protection
> rules here:
> https://github.com/serverless-heaven/serverless-webpack/settings/branches
>
> Untick appveyor & travis and tick Linter & Tests.
> And it should be fine :)
>
> Thanks!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/19/comments/4>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABKEZXSYDNN3I33YPD5YXRLSRSYQPANCNFSM4T5HC5OA>
> .
>
|
|
The Linter and Tests will show up after the GitHub Actions runs for the first time from recollection. I believe unchecking AppVeyor and Travis is needed for now. Requiring the Linter and Tests should be done after the PR merges and those options appear. |
|
As @miguel-a-calles-mba says, we should first disabled Travis and AppVeyor, then merge my PR and new checks will show up in the branch settings |
|
Ok. will do it this evening and ping here
…On Mon, Nov 30, 2020 at 9:47 PM Jérémy Benoist ***@***.***> wrote:
As @miguel-a-calles-mba <https://github.com/miguel-a-calles-mba> says, we
should first disabled Travis and AppVeyor, then merge my PR and new checks
will show up in the branch settings
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/19/comments/8>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXTKRPM5QNE5HVSSHM3SSQAF5ANCNFSM4T5HC5OA>
.
|
|
Let me know when you'll do it @HyperBrain. Travis is beginning to be awfully slow these days 😫 |
|
Hi @HyperBrain hope everything is fine. |
|
AppVeyor and Travis are now unticked. Let me know when the new ones will be visible |
|
Great! Thanks. New ones should be in place now as @miguel-a-calles-mba merged the PR |
|
Whoops. I wrote the message below yesterday, but forgot to hit send. @HyperBrain , the PR merged. You should now see "Tests" and "Linter" checks in the settings. They might have a GitHub logo. |
|
Will check as soon as I am at home
…On Thu, Jan 21, 2021 at 3:03 PM Miguel A. Calles MBA < ***@***.***> wrote:
Whoops. I wrote the message below yesterday, but forgot to hit send.
@HyperBrain <https://github.com/HyperBrain> , the PR merged. You should
now see "Tests" and "Linter" checks in the settings. They might have a
GitHub logo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/19/comments/14>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXW6WJVXJKAOBL6CYXLS3AX3LANCNFSM4T5HC5OA>
.
|
|
All ticked now |
|
... including coverage upload |
Uh oh!
There was an error while loading. Please reload this page.
Hello guys,
I would like to release 5.4.0 with some stuff we willing to package in it.
I ditched some of them. I don't know if we should put all PR from the milestone but I think we have enough stuff to push a release.
I'm waiting for some of them from their owner.
Also, I would like to ditch Travis and use GitHub Actions for tests. Travis has been sooo slow recently and GitHub Actions are pretty fast to be triggered.
What do you think?
All reactions