Drop requirement on coverage build

[j0k3r]

Hello @HyperBrain,

I hope you're fine.
Can you remove the requirement for the coverage/coveralls build?
I would arg against in the past to ensure the coverage doesn't drop too much but we have a case today which switch my POV.

One Serverless maintainer propose an update to the plugin about the upcoming v3 version of the framework. We can't test multiple version of the framework against the test suite so the coverage will drop anyway. Even with the addition of a custom build with Serverless pre-v3.
#1013

Thanks!

[vicary]

A gentle ping to @HyperBrain.

[HyperBrain]

Hi guys, sorry for the late reply. I will do that tomorrow evening.

…

On Sat, Mar 12, 2022 at 3:00 PM Vicary A. ***@***.***> wrote: A gentle ping to @HyperBrain <https://github.com/HyperBrain>. — Reply to this email directly, view it on GitHub <https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/23/comments/1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKEZXU7ZIDHWLKRON2F3Q3U7SPOVANCNFSM5JHICUWA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: <serverless-heaven/serverless-webpack-team/discussions/23/comments/1/@ github.com>

[HyperBrain]

I disabled the coveralls "no drop" requirement now in the coveralls settings.
However, coveralls is still run to be aware of the overall coverage. Please let me know if the issues are now fixed.
As coverage control ensured a good quality in the past (especially in the times where I was nearly the only one maintaining the project) we/you should consider activating it again at some point in the future to make sure that people always add proper tests for their submitted code.
Just saw - we still have an amazing 94% of coverage ;)

Additionally I want to take the time to say a big "thank you". Without your help the project would have been died due to my limited time in the past year.

Cheers
Frank

[j0k3r]

I agree with you.
That’s why we try to add e2e test to better test the missing part. But we are failing for now.
Thanks!

[j0k3r]

Hey @HyperBrain it looks like the requirement on GitHub is still here and we can't merge when the coverage drop ...
See #1018

[HyperBrain]

Ok. Then I need to check again today, where the remaining settings can be found. In the worst case I would just disable coveralls for the moment and enable it again as soon as possible.

…

On Wed, Mar 16, 2022 at 9:53 AM Jérémy Benoist ***@***.***> wrote: Hey @HyperBrain <https://github.com/HyperBrain> it looks like the requirement on GitHub is still here and we can't merge when the coverage drop ... See serverless-heaven/serverless-webpack#1018 <#1018> — Reply to this email directly, view it on GitHub <https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/23/comments/5>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKEZXWF4HI4V5FWUGNXPMTVAGOP3ANCNFSM5JHICUWA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: <serverless-heaven/serverless-webpack-team/discussions/23/comments/5/@ github.com>

[j0k3r]

If you can't find a solution on Coveralls side, maybe you can just disable the requirement on GitHub side.

[miguel-a-calles-mba]

It seems the code coverage dropped because there are no unit tests for this new function.
https://github.com/serverless-heaven/serverless-webpack/pull/1018/files#diff-bd3dad1576553f0425c8ed3f0aedb28cb66035b78e9461c300c4fc41871dffc0R34

[HyperBrain]

There is no setting on GitHub side and in Coveralls it is disabled:

Can it be that it needs to be run but ignored in the travis build file?

[j0k3r]

In fact, on Coveralls side you can leave the value to mark the build as fail if the drop is too important.

What you must update on GitHub side is the branch protection rules (here) and remove Coveralls in the section Require status checks to pass before merging so we'll be able to merge any PR with coverage drops because GitHub won't block it, only notify us.

[HyperBrain]

The branch protection rule is changed. I removed the necessity for coveralls.

[j0k3r]

Thanks!