Using WebChromeClient

[ajayjapan]

Hi,

I am trying to get this working with skip-web.

It looks like they require WebChromeClient.

I've tried forking skip-web but I am unable to get it to work. Any tips or suggestions?

https://docs.videosdk.live/prebuilt/guide/prebuilt-video-and-audio-calling/quick-start-android

[marcprux]

When you say you are unable to get it to work, were you encountering errors that you might share with us? Or did addition of the WebChromeClient simply not work for your needs? It looks like the code they say you need to use could be fairly straightforward to get working with Skip's Kotlin-ish syntax:

    myWebView.setWebViewClient(new WebViewClient());
    myWebView.setWebChromeClient(new WebChromeClient() {
      @Override
      public void onPermissionRequest(final PermissionRequest request) {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            request.grant(request.getResources());
        }
      }
    });

For experimentation, you also might be better off just bringing in your own simpler WebView wrapper, like the one at https://github.com/skiptools/skipapp-weather/blob/main/Sources/SkipWeather/WebView.swift. That will at least allow you to tweak various parts without needing to deal with the complexity of the skip-web implementation.

In any case, I think the implementation would look something like this:

#if SKIP
import android.webkit.WebView
import android.webkit.WebViewClient
import androidx.compose.runtime.Composable
import androidx.compose.ui.viewinterop.AndroidView

struct WebView: View {
    let url: URL
    let enableJavaScript: Bool

    init(url: URL, enableJavaScript: Bool = true) {
        self.url = url
        self.enableJavaScript = enableJavaScript
    }

    @Composable public override func ComposeContent(context: ComposeContext) {
        AndroidView(factory: { ctx in
            let webView = WebView(ctx)
            webView.webViewClient = WebViewClient()
            webView.webChromeClient = GrantAnyPermissionChromeClient()
            webView.settings.javaScriptEnabled = enableJavaScript
            return webView
        }, modifier: context.modifier, update: { webView in
            webView.loadUrl(url.absoluteString)
        })
    }
}

final class GrantAnyPermissionChromeClient: android.webkit.WebChromeClient {
    init() {
    }

    override func onPermissionRequest(request: android.webkit.PermissionRequest) {
        request.grant(request.getResources())
    }
}
#endif

[ajayjapan]

Hi,

I tried two ways first I tried modifying SkipWeb but this resulted in a white screen not loading anything. You can see the changes here: skiptools/skip-web@main...ajayjapan:skip-web:main

Then I also tried the SkipWeather way but was unable to get it to compile. Here are the two errors:

ERROR 1: .../ShowLiveStreamView_Bridge.swift:434:45 cannot find type 'android' in scope
NOTE: first line related to  "android.webkit.WebChromeClient"

final class GrantAnyPermissionChromeClient: android.webkit.WebChromeClient, BridgedFromKotlin, BridgedFinalClass {
    nonisolated private static let Java_class = try! JClass(name: "fantrance/module/GrantAnyPermissionChromeClient")
    nonisolated let Java_peer: JObject
    nonisolated required init(Java_ptr: JavaObjectPointer) {
        Java_peer = JObject(Java_ptr)
    }
    nonisolated static func fromJavaObject(_ obj: JavaObjectPointer?, options: JConvertibleOptions) -> Self {
        return .init(Java_ptr: obj!)
    }
    nonisolated func toJavaObject(options: JConvertibleOptions) -> JavaObjectPointer? {
        return Java_peer.safePointer()
    }

    init() {
        Java_peer = jniContext {
            let ptr = try! Self.Java_class.create(ctor: Self.Java_constructor_0_methodID, options: [], args: [])
            return JObject(ptr)
        }
    }
    nonisolated private static let Java_constructor_0_methodID = Java_class.getMethodID(name: "<init>", sig: "()V")!

ERROR 2:  .../SkipBridgeGenerated/ShowLiveStreamView_Bridge.swift:455:19 method does not override any method from its superclass
NOTE: seems like onPermissionRequest is not translated correctly hence not overriding anything

    override func onPermissionRequest(request p_0: AnyDynamicObject) {
        jniContext {
            let p_0_java = p_0.toJavaObject(options: [])!.toJavaParameter(options: [])
            try! Java_peer.call(method: Self.Java_onPermissionRequest_1_methodID, options: [], args: [p_0_java])
        }
    }
    nonisolated private static let Java_onPermissionRequest_1_methodID = Java_class.getMethodID(name: "onPermissionRequest", sig: "(Landroid/webkit/PermissionRequest;)V")!
}

Any help would be much appreciated. Thank you!

[marcprux]

I tried two ways first I tried modifying SkipWeb but this resulted in a white screen not loading anything. You can see the changes here: skiptools/skip-web@main...ajayjapan:skip-web:main

Hmm … that looks like it should work. Are you sure it is your additions that are preventing the page from showing? If you remove your modifications (or just comment them out), do other pages load and render OK?

I'm just wondering if everything is set up for your project to be able to use the WebView, like the permissions in your AndroidManifest.xml like:

    <uses-permission android:name="android.permission.INTERNET" />

Then I also tried the SkipWeather way but was unable to get it to compile. Here are the two errors:

Ahh, the example I cited was for a Skip Lite app. To get it working with Skip Fuse, you'd need to wrap it in #if !SKIP_BRIDGE (and likely make some other changes).

[ajayjapan]

Yes I have the android.permission.INTERNET in my AndroidManifest.xml.

www.google.com seems to load fine in the android simulator.

It looks to me like the page is loading but not displaying properly, as the i look at the Videosdk dashboard and it registers that someone is viewing the page.

Tried using SKIP_BRIDGE. Still getting the same errors. Here is the relevant code: https://gist.github.com/ajayjapan/50f80a9d43ed910c0bc7ad5bd1bb1837

The skip-web loads the page fine in iOS.