cleaner to be case (in)sensitive?

[pmoravec]

I would like to clarify how much case (in)sensitivity is desired with sos clean.

Most of the cleaner works case insensitive, meaning that e.g. foouser being obfuscated to obfuscateduser0, all FOOUSER strings are obfuscated to obfuscateduser0 as well. Or that foo.bar.example.com and FOO.bar.EXAMPLE.com are both matched the same way and obfuscated to the same host123.obfuscateddomain2.com - altogether in their appropriate case sensitivity. Meaning that /etc/sos/cleaner/default_mapping has:

        "bar.example.com": "obfuscateddomain2.com",
        "foo.bar.example.com": "host123.obfuscateddomain2.com",
        "bar.EXAMPLE.com": "obfuscateddomain2.com",
        "FOO.bar.EXAMPLE.com": "host123.obfuscateddomain2.com",
        "BAR.EXAMPLE.COM": "obfuscateddomain2.com",
        "FOO.BAR.EXAMPLE.COM": "HOST123.OBFUSCATEDDOMAIN2.COM"

This is achieved by re.I in any re.search/re.findall/re.match, while keeping mapping.dataset case sensitive.

I guess both are considered as features:

• case insensitive match
• case sensitive obfuscation of hostnames/domainnames

The reason why I ask: this means the mapping.dataset keeps duplicate keys (up to case sensitivity), which makes the dict "redundantly bigger". Relaxing from the "case sensitive obfuscation" feature, we can gain some performance improvement in handling smaller mapping.dataset.

But I think it is not worth changing. The performance gain would be small, ut we would loose some possibly valuable feature.

What are your thoughts?