Storage should return 404 in HTTP status code when object is not found

[l2dy]

Storage should respond with status code 404 instead of 400 if object is not found. This was previously proposed in supabase/storage#323 and it's clear that returning 400 is not semantically correct.

Returning 400 with a statusCode embedded in response body also makes it more difficult to differentiate different kind of failures without peaking into response body, which is more expensive for reverse proxies and middleware to implement.

https://github.com/supabase/storage/blob/6c2355f7be80e2bbb8206a720af34b96fd6f9506/src/storage/renderer/renderer.ts#L59-L66

      if (err.$metadata?.httpStatusCode === 404) {
        response.header('cache-control', 'no-store')
        return response.status(400).send({
          error: 'Not found',
          message: 'The resource was not found',
          statusCode: '404',
        })
      }