Update from 2.26.3 to 2.27.1 get api error

[klinux]

After upgrade I get this error in api server, someone had this issue?

I've upgrade the helm chart to: 3.28.1

Caused by: java.lang.NullPointerException: Cannot invoke "io.terrakube.api.rs.Organization.getName()" because the return value of "io.terrakube.api.rs.module.Module.getOrganization()" is null

terrakube-api-67f7877cfc-6shtv terrakube-api org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'moduleRefreshJob': Unsatisfied dependency expressed through field 'moduleRefreshService': Error creating bean with name 'moduleRefreshService': Invocation of init method failed
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:788) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:768) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:146) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:509) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1459) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:606) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:529) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:339) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:373) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:337) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultListableBeanFactory.instantiateSingleton(DefaultListableBeanFactory.java:1222) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingleton(DefaultListableBeanFactory.java:1188) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:1123) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:987) ~[spring-context-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:627) ~[spring-context-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:146) ~[spring-boot-3.5.4.jar:3.5.4]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:752) ~[spring-boot-3.5.4.jar:3.5.4]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:439) ~[spring-boot-3.5.4.jar:3.5.4]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.SpringApplication.run(SpringApplication.java:318) ~[spring-boot-3.5.4.jar:3.5.4]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1361) ~[spring-boot-3.5.4.jar:3.5.4]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1350) ~[spring-boot-3.5.4.jar:3.5.4]
terrakube-api-67f7877cfc-6shtv terrakube-api    at io.terrakube.api.ServerApplication.main(ServerApplication.java:18) ~[classes/:2.27.0]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.loader.launch.Launcher.launch(Launcher.java:102) ~[workspace/:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.loader.launch.Launcher.launch(Launcher.java:64) ~[workspace/:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.boot.loader.launch.JarLauncher.main(JarLauncher.java:40) ~[workspace/:na]
terrakube-api-67f7877cfc-6shtv terrakube-api Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'moduleRefreshService': Invocation of init method failed
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:222) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:429) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1818) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:607) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:529) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:339) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:373) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:337) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1683) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1628) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:785) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    ... 29 common frames omitted
terrakube-api-67f7877cfc-6shtv terrakube-api Caused by: java.lang.NullPointerException: Cannot invoke "io.terrakube.api.rs.Organization.getName()" because the return value of "io.terrakube.api.rs.module.Module.getOrganization()" is null
terrakube-api-67f7877cfc-6shtv terrakube-api    at io.terrakube.api.plugin.scheduler.module.ModuleRefreshService.initModuleRefreshJob(ModuleRefreshService.java:47) ~[classes/:2.27.0]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleMethod.invoke(InitDestroyAnnotationBeanPostProcessor.java:457) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleMetadata.invokeInitMethods(InitDestroyAnnotationBeanPostProcessor.java:401) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:219) ~[spring-beans-6.2.9.jar:6.2.9]
terrakube-api-67f7877cfc-6shtv terrakube-api    ... 40 common frames omitted

[alfespa17]

Try checking the module table and validate if there is a module without the organization_id (it should not exist)

It is failing in this part of the code that is refreshing the module version at startup, so I guess maybe there is some invalid data in the module table

terrakube/api/src/main/java/io/terrakube/api/plugin/scheduler/module/ModuleRefreshService.java

Line 46 in b3b90e7

log.info("Module {}/{}/{} has no versions in the database, creating a scheduler job to fetch the versions",

[klinux]

Not even provider

[klinux]

the / in the provider can be a problem?

[klinux]

Yes, the demo orgs is disabled

[alfespa17]

that is the issue, there should be a module using that org that is disable

[klinux]

ok I will enable it and test

[alfespa17]

There is a validation in this entity that will only take values that are enabled

terrakube/api/src/main/java/io/terrakube/api/rs/Organization.java

Line 50 in b3b90e7

@SQLRestriction(value = "disabled = false")

This part of the code is taking all modules in the table without validating if some of those are using a disabled org

terrakube/api/src/main/java/io/terrakube/api/plugin/scheduler/module/ModuleRefreshService.java

Line 37 in b3b90e7

List<Module> modules = moduleRepository.findAll();

[klinux]

@alfespa17 thank you, it works now, my bad, I don't realize that

[alfespa17]

I will have to add some logic in that method to correctly manage disabled orgs