Replies: 2 comments 6 replies
-
You should probably use them and let tmux decide what to do with them depending on the features of the outside terminals. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Falling back to plain underscore to show something is there seems more useful than not showing anything at all, but I don't feel particularly strongly about it and I doubt any users will care, so I could be convinced (ideally by a PR)... I do think we should do the same thing for all the extra underscore styles though and not a mix of behaviours. |
Beta Was this translation helpful? Give feedback.
6 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Commit bc0e527 (Support for extended underline styles on terminals .. 2018-10-18)
added support for things like curly underline (
\e[4:3m
)but if terminfo does not advertise support for this (
Su
/Smulx
),tmux will output a straight underline instead.
Similar behavior exists in Emacs ansi-term and emacs-vterm, GNU screen and Vim's :terminal.
But not in XTerm and most other "non-nested" terminals that don't support curly underlines yet - they simply ignore
\e[4:3m
.I wonder why tmux' behavior is desirable? I guess it seems like helpful for other underline styles but not so much for the case where curly underlines should indicate a syntax error.
We're looking for a way to circumvent it, see fish-shell/fish-shell#11388 (comment)
Our goal is to not emit any underline if tmux' underlying terminal does not support it.
Are we supposed to use
tmux display-message -p '#{client_termname}'
and read its terminfo?Or does tmux expose the value of
tty_term_has(tty->term, TTYC_SMULX)
?There are also passthrough sequences which we could use to by pass tmux but I don't think that tmux enables them by default.
I'm mainly interested in things that can work out-of-the-box.
Beta Was this translation helpful? Give feedback.
All reactions