persistent cache build dependency warning when "module" imported from esm build dependency

[youngderekm]

Bug report

What is the current behavior?
My webpack configuration is an es module (webpack.config.mjs). It imports a file from another es module (type: "module") that imports createRequire from "module" in order to use require.resolve. I have cache.type = 'filesystem'. When the build dependencies are scanned, I get a warning that 'module' can't be resolved:

<w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: Can't resolve 'module' in 'C:\sand\webinst-webpack\webcommons\tools\client\webpack\target\tsc'
<w> while resolving 'module' in C:\sand\webinst-webpack\webcommons\tools\client\webpack\target\tsc as file
<w>  at resolve esm file module
<w>  at file dependencies C:\sand\webinst-webpack\webcommons\tools\client\webpack\target\tsc\WebpackConfig.js
<w>  at file C:\sand\webinst-webpack\webcommons\tools\client\webpack\target\tsc\WebpackConfig.js
<w>  at resolve commonjs C:\sand\webinst-webpack\webcommons\tools\client\webpack\target\tsc\WebpackConfig.js

If the current behavior is a bug, please provide the steps to reproduce.

In webpack.config.mjs:

import {WebpackConfig} from "webpack-config";

from webpack-config/index.js:

import {createRequire} from "module";
const require = createRequire(import.meta.url);

....

    cache: {
      type: "filesystem",
    }

webpack-config/package.json has "type": "module".

use webpack serve.
warning is logged to the console.

What is the expected behavior?
Imports from built in node modules (like 'module') should be ignored.

Other relevant information:
webpack version: 5.51.2
Node.js version: v16.13.0
Operating System: Windows 10
Additional tools:

[alexander-akait]

I don't think it is related to webpack (look at stack trace), if you need help please create reproducible example and I will show you how to fix

[alexander-akait]

Weird bug, if you change import {createRequire} from "module"; on single import {createRequire} from 'module'; all works fine (except we can't resolve Node.js deps, but it is expected for ESM), problems in quotes, maybe bug in es-module-lexer, investigating

[alexander-akait]

#14709, sorry for delay, I moved it to discussion very early, sorry again

[alexander-akait]

Solved #14687, update lock file

[youngderekm]

Thank you for looking into this. I tried again with 5.63.0 that has the quote fix and now single quotes or double quotes produce the same behavior. But I still get the warning about node modules:

Caching failed for pack: Error: Can't resolve 'module' in 'C:\sand\webpack-cache-esm'

And when that happens, nothing is written into the cache (node_modules/.cache isn't created). Shouldn't node dependencies (path, module, url, etc.) just be ignored? Is it possible to use the filesystem cache with an esm config file with node dependencies?

[alexander-akait]

Unfortunately, this is a limitation on Node.js side (we are working on it), honestly ESM part on Node.js side is not finished, many things are experimental, you can move them into file.cjs file and do logic there, and only export evaluated variables, yes, it is annoying and inconvenient, but no solution right now, hope we will improve it in near future

[weimengxi]

I've met the same problem.

[vankop]

should be solved in latest webpack version. feel free to create repro.

[yejinjian]

I have met the same problem in version 5.93.0

[alexander-akait]

Please create reproducible test repo